Redacting MSC2716 related events

[MadLittleMods]

What should happen when you redact MSC2716 related events? @erikjohnston does this look sane?

• "insertion" event
  • Undo the steps we take in _handle_insertion_event
  • Remove from the insertion_events table
  • Remove all of the insertion_event_edges
• "chunk" event
  • Undo the steps we take in _handle_chunk_event
  • Remove from chunk_events
• "marker" event
  • not merged yet, see Add support for MSC2716 marker events (federation) #10498
  • Undo the steps we take in _handle_marker_event
  • We backfill the insertion event in _handle_marker_event but I don't think we need to undo that. If they want to redact the insertion event, they can do that separately. We can just redact the "marker" event as normal with no special logic.

---

A more general question but what happens when you redact a redaction? Does it cancel the event being redacted?

[erikjohnston]

I think we should probably add those fields to be included in the redacted event, so that the structure of the imported history isn't lost. The idea of redaction is that you can use it to strip out fields from events without affecting anything at the protocol level.

A more general question but what happens when you redact a redaction? Does it cancel the event being redacted?

I don't think anything happens, as it won't strip out the redacts field

[MadLittleMods]

The idea of redaction is that you can use it to strip out fields from events without affecting anything at the protocol level.

Interesting. Didn't realize that was the goal of redacting 👨‍🌾

Created #10538 to maintain the structural fields around 👍