Merge pull request #14 from matrix-org/michaelk/raise_exception_for_unknown_action

MidhunSureshR · web-flow · commit 74c89d2fbaf9 · 2022-11-28T14:07:41.000+05:30
Raise an exception if you have an unknown action.
diff --git a/cypress/e2e/trafficlight/trafficlight.spec.ts b/cypress/e2e/trafficlight/trafficlight.spec.ts
@@ -295,7 +295,6 @@ function runAction(action: string, data: JSONValue): string | undefined {
             cy.log('Client asked to exit, test complete or server teardown');
             return;
         default:
-            cy.log('WARNING: unknown action ', action);
-            return;
+            throw new Error(`WARNING: unknown action "${action}"`);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,6 @@ function runAction(action: string, data: JSONValue): string \| undefined {`
`295`	`295`	`cy.log('Client asked to exit, test complete or server teardown');`
`296`	`296`	`return;`
`297`	`297`	`default:`
`298`		`- cy.log('WARNING: unknown action ', action);`
`299`		`- return;`
	`298`	+ throw new Error(`WARNING: unknown action "${action}"`);
`300`	`299`	`}`
`301`	`300`	`}`