conference: accept the metadata from the DC offer

Author: daniel-abramov

pkg/conference/processor.go

@@ -184,6 +184,8 @@ func (c *Conference) handleDataChannelMessage(participant *Participant, sfuMessa
 			return
 		}
 
+		participant.streamMetadata = sfuMessage.Metadata
+
 		participant.sendDataChannelMessage(event.SFUMessage{
 			Op:       event.SFUOperationAnswer,
 			SDP:      answer.SDP,
@@ -197,12 +199,6 @@ func (c *Conference) handleDataChannelMessage(participant *Participant, sfuMessa
 	case event.SFUOperationAlive:
 		// FIXME: Handle the heartbeat message here (updating the last timestamp etc).
 	case event.SFUOperationMetadata:
-		streamIDs := make([]string, 0, len(sfuMessage.Metadata))
-		for streamID := range sfuMessage.Metadata {
-			streamIDs = append(streamIDs, streamID)
-		}
-		participant.logger.Infof("Received metadata over DC: %v", streamIDs)
-
 		participant.streamMetadata = sfuMessage.Metadata
 		c.resendMetadataToAllExcept(participant.id)
 	}

pkg/conference/state.go

@@ -82,14 +82,6 @@ func (c *Conference) getAvailableStreamsFor(forParticipant ParticipantID) event.
 					streamsMetadata[streamID] = metadata
 				} else {
 					participant.logger.Warnf("Don't have metadata for stream %s", streamID)
-					// FIXME: A hacky way to nevertheless send a metadata about the stream and track for which we have
-					//        no metadata. This is against the MSC actually since we know nothing about the stream in
-					//        this case. But it was implemented like this in the `main`	branch of the SFU.
-					streamsMetadata[streamID] = event.CallSDPStreamMetadataObject{
-						UserID:   participant.id.UserID,
-						DeviceID: participant.id.DeviceID,
-						Tracks:   event.CallSDPStreamMetadataTracks{trackID: event.CallSDPStreamMetadataTrack{}},
-					}
 				}
 			}
 		}