Merge pull request #58 from matrix-org/addresss-refactoring-leftovers

Addresss left-overs from Dave's review

Author: daniel-abramov

pkg/common/message_sink.go

@@ -16,8 +16,10 @@ type MessageSink[SenderType comparable, MessageType any] struct {
 	// The message sink to which the messages are sent.
 	messageSink chan<- Message[SenderType, MessageType]
 	// Atomic variable that indicates whether the message sink is sealed.
-	// This is used to prevent sending messages to a sealed message sink.
-	// The variable is atomic because it may be accessed from multiple goroutines.
+	// Basically it means that **the current sender** (but not other senders)
+	// won't be able to send any more messages to the message sink. The difference
+	// between this and the channel being closed is that the closed channel is not
+	// available for writing for all senders.
 	sealed atomic.Bool
 }
 

pkg/conference/participant.go

@@ -50,6 +50,7 @@ func (p *Participant) sendDataChannelMessage(toSend event.SFUMessage) {
 	jsonToSend, err := json.Marshal(toSend)
 	if err != nil {
 		p.logger.Error("Failed to marshal data channel message")
+		return
 	}
 
 	if err := p.peer.SendOverDataChannel(string(jsonToSend)); err != nil {