Skip to content

Commit 6433cbd

Browse files
Revert "peer: use GatheringCompletePromise from Pion"
This reverts commit 9d20fb3.
1 parent 9d20fb3 commit 6433cbd

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

pkg/peer/peer.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,16 +180,12 @@ func (p *Peer[ID]) ProcessSDPOffer(sdpOffer string) (*webrtc.SessionDescription,
180180
return nil, ErrCantCreateAnswer
181181
}
182182

183-
// TODO: Do we really need to call `webrtc.GatheringCompletePromise` here?
184-
gatherComplete := webrtc.GatheringCompletePromise(p.peerConnection)
185-
186183
if err := p.peerConnection.SetLocalDescription(answer); err != nil {
187184
p.logger.WithError(err).Error("failed to set local description")
188185
return nil, ErrCantSetLocalDescription
189186
}
190187

191-
// Block until ICE Gathering is complete.
192-
<-gatherComplete
188+
// TODO: Do we really need to call `webrtc.GatheringCompletePromise` here?
193189

194190
sdpAnswer := p.peerConnection.LocalDescription()
195191
if sdpAnswer == nil {

0 commit comments

Comments
 (0)