peer: don't fail on certain RTCP write errors

daniel-abramov · daniel-abramov · commit b8850c2c1610 · 2022-11-30T14:13:40.000+01:00
diff --git a/pkg/peer/webrtc.go b/pkg/peer/webrtc.go
@@ -21,8 +21,8 @@ func (p *Peer[ID]) onRtpTrackReceived(remoteTrack *webrtc.TrackRemote, receiver
 		ticker := time.NewTicker(time.Millisecond * 500) // every 500ms
 		for range ticker.C {
 			rtcp := []rtcp.Packet{&rtcp.PictureLossIndication{MediaSSRC: uint32(remoteTrack.SSRC())}}
-			if rtcpSendErr := p.peerConnection.WriteRTCP(rtcp); rtcpSendErr != nil {
-				p.logger.Errorf("Failed to send RTCP PLI: %v", rtcpSendErr)
+			if err := p.peerConnection.WriteRTCP(rtcp); err != nil && !errors.Is(err, io.ErrClosedPipe) {
+				p.logger.Errorf("Failed to send RTCP PLI: %v", err)
 				return
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -21,8 +21,8 @@ func (p Peer[ID]) onRtpTrackReceived(remoteTrack webrtc.TrackRemote, receiver`
`21`	`21`	`ticker := time.NewTicker(time.Millisecond * 500) // every 500ms`
`22`	`22`	`for range ticker.C {`
`23`	`23`	`rtcp := []rtcp.Packet{&rtcp.PictureLossIndication{MediaSSRC: uint32(remoteTrack.SSRC())}}`
`24`		`- if rtcpSendErr := p.peerConnection.WriteRTCP(rtcp); rtcpSendErr != nil {`
`25`		`- p.logger.Errorf("Failed to send RTCP PLI: %v", rtcpSendErr)`
	`24`	`+ if err := p.peerConnection.WriteRTCP(rtcp); err != nil && !errors.Is(err, io.ErrClosedPipe) {`
	`25`	`+ p.logger.Errorf("Failed to send RTCP PLI: %v", err)`
`26`	`26`	`return`
`27`	`27`	`}`
`28`	`28`	`}`