Skip to content

Commit ba10bd7

Browse files
committed
Clear up munging
Signed-off-by: Šimon Brandner <[email protected]>
1 parent cbe9107 commit ba10bd7

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/subscriber.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,18 +127,19 @@ func (s *Subscriber) forwardRTCP() {
127127

128128
packetsToForward := []rtcp.Packet{}
129129
readSSRC := uint32(s.publisher.Track.SSRC())
130-
senderSSRC := uint32(s.sender.GetParameters().Encodings[0].SSRC)
131130

132131
for _, packet := range packets {
133132
switch typedPacket := packet.(type) {
134133
// We mung the packets here, so that the SSRCs match what the
135-
// receiver expects
134+
// receiver expects:
135+
// The media SSRC is the SSRC of the media about which the packet is
136+
// reporting; therefore, we mung it to be the SSRC of the publishing
137+
// participant's track. Without this, it would be SSRC of the SFU's
138+
// track which isn't right
136139
case *rtcp.PictureLossIndication:
137-
typedPacket.SenderSSRC = senderSSRC
138140
typedPacket.MediaSSRC = readSSRC
139141
packetsToForward = append(packetsToForward, typedPacket)
140142
case *rtcp.FullIntraRequest:
141-
typedPacket.SenderSSRC = senderSSRC
142143
typedPacket.MediaSSRC = readSSRC
143144
packetsToForward = append(packetsToForward, typedPacket)
144145
}

0 commit comments

Comments
 (0)