conference: update TODOs and FIXMEs

Author: daniel-abramov

pkg/conference/participant.go

@@ -45,7 +45,7 @@ func (p *Participant) sendDataChannelMessage(toSend event.SFUMessage) {
 	}
 
 	if err := p.peer.SendOverDataChannel(string(jsonToSend)); err != nil {
-		// FIXME: We must buffer the message in this case and re-send it once the data channel is recovered!
+		// TODO: We must buffer the message in this case and re-send it once the data channel is recovered!
 		p.logger.Error("Failed to send data channel message")
 	}
 }

pkg/peer/webrtc.go

@@ -103,10 +103,10 @@ func (p *Peer[ID]) onNegotiationNeeded() {
 func (p *Peer[ID]) onICEConnectionStateChanged(state webrtc.ICEConnectionState) {
 	p.logger.WithField("state", state).Info("ICE connection state changed")
 
-	// TODO: Ask Simon if we should do it here as in the previous implementation.
 	switch state {
 	case webrtc.ICEConnectionStateFailed, webrtc.ICEConnectionStateDisconnected:
-		// TODO: We may want to treat it as an opportunity for the ICE restart instead.
+		// TODO: Ask Simon if we should do it here as in the previous implementation.
+		//       Ideally we want to perform an ICE restart here.
 		// p.notify <- PeerLeftTheCall{sender: p.data}
 	case webrtc.ICEConnectionStateCompleted, webrtc.ICEConnectionStateConnected:
 		// FIXME: Start keep-alive timer over the data channel to check the connecitons that hanged.

pkg/router.go

@@ -145,7 +145,6 @@ func (r *Router) handleMatrixEvent(evt *event.Event) {
 			delete(r.conferenceSinks, conferenceID)
 			// Since we were not able to send the message, let's re-process it now.
 			// Note, we probably do not want to block here!
-			// TODO: Do it better (use buffered channels or something).
 			r.handleMatrixEvent(evt)
 		}
 	}