fix matter binding detele error (#1232)

Author: Luxni

dashboard/src/components/dialogs/acl/model.ts

@@ -1,18 +1,18 @@
 
+export type AccessControlTargetStruct = {
+  cluster: number | undefined;
+  endpoint: number | undefined;
+  deviceType: number | undefined;
+};
+
 export type AccessControlEntryRawInput = {
   "1": number;
   "2": number;
   "3": number[];
-  "4": null;
+  "4": AccessControlTargetStruct[] | undefined;
   "254": number;
 };
 
-export type AccessControlTargetStruct = {
-  cluster: number | undefined;
-  endpoint: number | undefined;
-  deviceType: number | undefined;
-};
-
 export type AccessControlEntryStruct = {
   privilege: number;
   authMode: number;
@@ -95,15 +95,6 @@ export class AccessControlEntryDataTransformer {
       }
     }
 
-    if (
-      result.privilege === undefined ||
-      result.authMode === undefined ||
-      result.subjects === undefined ||
-      result.fabricIndex === undefined
-    ) {
-      throw new Error("Missing required fields in AccessControlEntryStruct");
-    }
-
     return result as AccessControlEntryStruct;
   }
 }

dashboard/src/components/dialogs/binding/model.ts

@@ -47,15 +47,6 @@ export class BindingEntryDataTransformer {
       }
     }
 
-    // Validate required fields
-    if (
-      result.node === undefined ||
-      result.endpoint === undefined ||
-      result.fabricIndex === undefined
-    ) {
-      throw new Error("Missing required fields in BindingEntryStruct");
-    }
-
     return result as BindingEntryStruct;
   }
 }

dashboard/src/components/dialogs/binding/node-binding-dialog.ts

@@ -57,7 +57,6 @@ export class NodeBindingDialog extends LitElement {
   private fetchACLEntry(targetNodeId: number): AccessControlEntryStruct[] {
     const acl_cluster_raw: [InputType] =
       this.client.nodes[targetNodeId].attributes["0/31/0"];
-
     return Object.values(acl_cluster_raw).map((value: InputType) =>
       AccessControlEntryDataTransformer.transform(value),
     );
@@ -67,9 +66,10 @@ export class NodeBindingDialog extends LitElement {
     const rawBindings = this.fetchBindingEntry();
     try {
       const targetNodeId = rawBindings[index].node;
+      const endpoint = rawBindings[index].endpoint;
       await this.removeNodeAtACLEntry(
         this.node!.node_id,
-        this.endpoint,
+        endpoint,
         targetNodeId,
       );
       const updatedBindings = this.removeBindingAtIndex(rawBindings, index);
@@ -92,23 +92,21 @@ export class NodeBindingDialog extends LitElement {
       )
       .filter((entry): entry is Exclude<typeof entry, null> => entry !== null);
 
-    console.log(updatedACLEntries);
     await this.client.setACLEntry(targetNodeId, updatedACLEntries);
   }
 
   private removeEntryAtACL(
     nodeId: number,
     sourceEndpoint: number,
     entry: AccessControlEntryStruct,
-  ): AccessControlEntryStruct | null {
+  ): AccessControlEntryStruct | undefined {
     const hasSubject = entry.subjects!.includes(nodeId);
-
     if (!hasSubject) return entry;
 
     const hasTarget = entry.targets!.filter(
       (item) => item.endpoint === sourceEndpoint,
     );
-    return hasTarget.length > 0 ? null : entry;
+    return hasTarget.length > 0 ? undefined : entry;
   }
 
   private removeBindingAtIndex(
@@ -216,7 +214,7 @@ export class NodeBindingDialog extends LitElement {
       return;
     }
     if (isNaN(targetCluster) || targetCluster < 0) {
-      alert("Please enter a valid target endpoint");
+      alert("Please enter a valid target cluster");
       return;
     }
 
@@ -234,7 +232,10 @@ export class NodeBindingDialog extends LitElement {
       fabricIndex: this.client.connection.serverInfo!.fabric_id,
     };
     const result_acl = await this.add_target_acl(targetNodeId, acl_entry);
-    if (!result_acl) return;
+    if (!result_acl) {
+      alert("add target acl error!");
+      return;
+    }
 
     const endpoint = this.endpoint;
     const bindingEntry: BindingEntryStruct = {