[mlir] Address clang-tidy remarks. NFC

Author: abinavpp

libsolidity/codegen/mlir/Passes.cpp

@@ -27,7 +27,6 @@
 #include "mlir/Transforms/Passes.h"
 #include "llvm-c/Core.h"
 #include "llvm-c/Target.h"
-#include "llvm-c/TargetMachine.h"
 #include "llvm-c/Transforms/PassBuilder.h"
 #include "llvm-c/Types.h"
 #include "llvm/ADT/SmallString.h"
@@ -229,8 +228,6 @@ static mlir::ModuleOp extractRuntimeModule(mlir::ModuleOp creationMod) {
   return {};
 }
 
-DEFINE_SIMPLE_CONVERSION_FUNCTIONS(llvm::TargetMachine, LLVMTargetMachineRef)
-
 static LLVMMemoryBufferRef genObj(llvm::Module &mod,
                                   llvm::TargetMachine &tgtMach) {
   LLVMTargetMachineRef tgtMachWrapped = wrap(&tgtMach);

libsolidity/codegen/mlir/Passes.h

@@ -30,6 +30,7 @@
 #include "mlir/Pass/PassManager.h"
 #include "mlir/Support/LLVM.h"
 #include "mlir/Transforms/DialectConversion.h"
+#include "llvm-c/TargetMachine.h"
 #include "llvm/IR/Module.h"
 #include "llvm/Target/TargetMachine.h"
 #include <memory>
@@ -92,3 +93,7 @@ genEvmBytecode(frontend::ContractDefinition const *cont,
 Bytecode genEraVMBytecode(llvm::Module &llvmMod, llvm::TargetMachine &tgtMach);
 
 } // namespace solidity::mlirgen
+
+namespace llvm {
+DEFINE_SIMPLE_CONVERSION_FUNCTIONS(llvm::TargetMachine, LLVMTargetMachineRef)
+}

libsolidity/codegen/mlir/Target/EraVM/YulToStandard.cpp

@@ -52,8 +52,6 @@
 
 using namespace mlir;
 
-namespace {
-
 /// Returns true if `op` is defined in a runtime context
 static bool inRuntimeContext(Operation *op) {
   assert(!isa<sol::FuncOp>(op) && !isa<yul::ObjectOp>(op));
@@ -72,6 +70,8 @@ static bool inRuntimeContext(Operation *op) {
   llvm_unreachable("op has no parent FuncOp or ObjectOp");
 }
 
+namespace {
+
 struct Keccak256OpLowering : public OpRewritePattern<yul::Keccak256Op> {
   using OpRewritePattern<yul::Keccak256Op>::OpRewritePattern;