Skip to content

Commit 859ffce

Browse files
committed
fix(ci): bump deprecated actions/download-artifact and actions/upload-artifact v3 to v4
1 parent 822c276 commit 859ffce

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

.github/workflows/test-gpu.yaml

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -71,26 +71,29 @@ jobs:
7171
rustup toolchain install nightly-2024-08-01
7272
rustup default nightly-2024-08-01
7373
74-
- name: Build tests and copy binaries to a separate dir
74+
- name: Build tests and copy binary to a separate dir
7575
shell: bash
7676
run: |
7777
mkdir artifacts
7878
CUDAARCHS=80 CARGO_TARGET_DIR=./build \
7979
cargo +nightly-2024-08-01 test -p ${{ matrix.package }} --no-run --release --message-format=json -q \
8080
| jq -r 'select(.executable != null) | .executable' \
8181
| while read binary; do
82-
cp "$binary" artifacts/
82+
cp "$binary" artifacts/${{ matrix.package }}
8383
done
8484
85-
- name: Upload test binaries as a single artifact
86-
uses: actions/upload-artifact@v3
85+
- name: Upload test binary
86+
uses: actions/upload-artifact@v4
8787
with:
88-
name: zksync-crypto-gpu-${{ matrix.cuda }}-test-binaries
89-
path: artifacts/
88+
name: zksync-crypto-gpu-${{ matrix.cuda }}-${{ matrix.package }}-test-binary
89+
path: artifacts/${{ matrix.package }}
9090
if-no-files-found: error
9191

9292
zksync-crypto-gpu-test:
9393
runs-on: [ matterlabs-ci-gpu-runner ]
94+
strategy:
95+
matrix:
96+
package: [ "era_cudart", "boojum-cuda", "shivini" ]
9497
needs: zksync-crypto-gpu-build
9598
env:
9699
BELLMAN_CUDA_DIR: ${{ github.workspace }}/bellman-cuda
@@ -116,31 +119,27 @@ jobs:
116119
tar xvfz bellman-cuda.tar.gz -C ./bellman-cuda
117120
tar xvfz bellman-cuda-source.tar.gz -C ./bellman-cuda --strip-components=1 --wildcards \*/src/
118121
119-
- name: Download test binaries built with CUDA 12.0
120-
uses: actions/download-artifact@v3
122+
- name: Download test binary built with CUDA 12.0
123+
uses: actions/download-artifact@v4
121124
with:
122-
name: zksync-crypto-gpu-12.0.0-devel-ubuntu20.04-test-binaries
123-
path: zksync-crypto-gpu-test-binaries/12.0
125+
name: zksync-crypto-gpu-12.0.0-devel-ubuntu20.04-${{ matrix.package }}-test-binary
126+
path: zksync-crypto-gpu-test-binary/12.0/
124127

125-
- name: Download test binaries built with CUDA 12.5
126-
uses: actions/download-artifact@v3
128+
- name: Download test binary built with CUDA 12.5
129+
uses: actions/download-artifact@v4
127130
with:
128-
name: zksync-crypto-gpu-12.5.0-devel-ubuntu20.04-test-binaries
129-
path: zksync-crypto-gpu-test-binaries/12.5
131+
name: zksync-crypto-gpu-12.5.0-devel-ubuntu20.04-${{ matrix.package }}-test-binary
132+
path: zksync-crypto-gpu-test-binary/12.5/
130133

131-
- name: Run test binaries built with CUDA 12.5
134+
- name: Run test binary built with CUDA 12.5
132135
id: test_cuda_12_5
133136
continue-on-error: true
134137
run: |
135-
for binary in zksync-crypto-gpu-test-binaries/12.5/*; do
136-
chmod +x $binary
137-
$binary
138-
done
138+
chmod +x zksync-crypto-gpu-test-binary/12.5/${{ matrix.package }}
139+
zksync-crypto-gpu-test-binary/12.5/${{ matrix.package }}
139140
140-
- name: Run test binaries built with CUDA 12.0
141+
- name: Run test binary built with CUDA 12.0
141142
if: steps.test_cuda_12_5.outcome == 'failure' || steps.test_cuda_12_5.outcome == 'success'
142143
run: |
143-
for binary in zksync-crypto-gpu-test-binaries/12.0/*; do
144-
chmod +x $binary
145-
$binary
146-
done
144+
chmod +x zksync-crypto-gpu-test-binary/12.0/${{ matrix.package }}
145+
zksync-crypto-gpu-test-binary/12.0/${{ matrix.package }}

0 commit comments

Comments
 (0)