Skip to content

Uninitialized data access issue fixed#37

Open
olesHolem wants to merge 1 commit intomainfrom
oh_uninit_data_access_fix
Open

Uninitialized data access issue fixed#37
olesHolem wants to merge 1 commit intomainfrom
oh_uninit_data_access_fix

Conversation

@olesHolem
Copy link
Contributor

@olesHolem olesHolem commented Oct 22, 2024

What ❔

This PR adds data_is_set field to structures AsyncVec and DeviceBuf to track if inner data is correct and defined.

Why ❔

Currently, it's possible to get access to uninitialized data. The simplest way is through allocate_new and get_values method of AsyncVec.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(boojum-cuda): Expose more public methods
  • fix(gpu-ffi): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

No release type found in pull request title "Uninitialized data access issue fixed". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@robik75
Copy link
Member

robik75 commented Jan 9, 2025

@olesHolem Do you still want to include merge this PR or should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olesHolem @robik75