Skip to content

Commit 175bc6a

Browse files
Update desktop-release-process.md (#1491)
Some updates to the release process. Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>
1 parent 24abe80 commit 175bc6a

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

site/content/internal/desktop-release-process.md

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ weight: 101
1212

1313
Before starting a new release, you want to make sure you do a few things:
1414
- Check to make sure that there are no further Bug or Story tickets waiting to be merged. You can check JIRA to see if there are any tickets with the Fix version: `vX.Y Desktop App`. If there are, you'll want to wait until those have been merged.
15+
- For major/minor releases, check to make sure that an Electron upgrade has been done shortly before the release. It's important to keep up with the latest security changes in Electron and Chrome.
1516

1617
- If you work off of a fork of the `mattermost/desktop` repository, make sure your local master branch is up to date:
1718
```
@@ -31,12 +32,12 @@ Before starting a new release, you want to make sure you do a few things:
3132
3233
## Start a new release
3334
34-
1. For a new major or minor release, check out the `master` branch and create a new release branch from it.
35+
1. For a new major or minor release, check out the `master` branch and create a new release branch from it
3536
```
3637
git checkout master
3738
git checkout -b release-X.Y
3839
```
39-
For a patch release, just check out the existing release branch matching the version you're patching.
40+
For a patch release, or if the branch already exists, just check out the existing release branch matching the version you're patching.
4041
```
4142
git checkout release-X.Y
4243
```
@@ -88,8 +89,8 @@ You can then follow steps **5-8** above to make sure the release is published.
8889
8990
Once the final release candidate has been approved by QA, you will need approval from the Mac App Store. To do so, we create a special release for them:
9091
```
91-
git checkout -b release-X.Y
92-
./scripts/release.sh mas
92+
git checkout release-X.Y
93+
./scripts/release.sh pre-final
9394
git push --follow-tags upstream release-X.Y:release-X.Y
9495
```
9596
@@ -116,15 +117,9 @@ If the app is **rejected** by App Review, you will get an email from App Store C
116117
117118
Once the app has been approved by all parties, we can cut the final release:
118119
```
119-
git checkout -b release-X.Y
120+
git checkout release-X.Y
120121
./scripts/release.sh final
121122
git push --follow-tags upstream release-X.Y:release-X.Y
122123
```
123124
124-
You can then follow steps **5-8** above to make sure the release is published, but make sure that the checkbox for 'set as pre-release` is unchecked.
125-
126-
### Final Steps
127-
128-
Afterwards, you will need to update the [`ci/latest`](https://git.internal.mattermost.com/ci/latest) repository in GitLab to update the latest version of the Desktop App available on mattermost.com.
129-
130-
In that repository there is a file called `release-updates.vars`, and in that file there is a line that says `DESKTOP_STREAM_LATEST`. You can replace that version number with the one you just released, and submit a PR to be reviewed by Release team.
125+
You can then follow steps **5-8** from the "Start a new release" section above to make sure the release is published, but make sure that the checkbox for 'Set as pre-release` is unchecked.

0 commit comments

Comments
 (0)