Skip to content

Commit 64ffb6d

Browse files
committed
removed reducer/selector for mentions
1 parent dca28e6 commit 64ffb6d

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

webapp/src/reducers/index.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,6 @@ function sidebarContent(state = {
107107
}
108108
}
109109

110-
function mentionDetails(state: PrsDetailsData[] = [], action: {type: string, data: PrsDetailsData[]}) {
111-
switch (action.type) {
112-
case ActionTypes.RECEIVED_YOUR_PRS_DETAILS:
113-
return action.data;
114-
default:
115-
return state;
116-
}
117-
}
118-
119110
function yourRepos(state: YourReposData[] = [], action: {type: string, data: YourReposData[]}) {
120111
switch (action.type) {
121112
case ActionTypes.RECEIVED_REPOSITORIES:
@@ -233,7 +224,6 @@ export default combineReducers({
233224
configuration,
234225
clientId,
235226
reviewDetails,
236-
mentionDetails,
237227
yourRepos,
238228
yourPrDetails,
239229
mentions,

webapp/src/selectors.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ export const getSidebarData = createSelector(
5252
getPluginState,
5353

5454
(pluginState): SidebarData => {
55-
const {username, mentionDetails, sidebarContent, reviewDetails, yourPrDetails, organization, rhsState} = pluginState;
55+
const {username, sidebarContent, reviewDetails, yourPrDetails, organization, rhsState} = pluginState;
5656
return {
5757
username,
58-
mentions: mapPrsToDetails(sidebarContent.mentions || emptyArray, mentionDetails),
58+
mentions: sidebarContent.mentions || emptyArray,
5959
reviews: mapPrsToDetails(sidebarContent.reviews || emptyArray, reviewDetails),
6060
yourPrs: mapPrsToDetails(sidebarContent.prs || emptyArray, yourPrDetails),
6161
yourAssignments: sidebarContent.assignments || emptyArray,

0 commit comments

Comments
 (0)