Added testcase for some functions in server/command.go (#845)

* Template PR for server unit test cases

* Fixed lint errors

* added testcase for some functions in server/api.go

* addede testcase for some functions in server/command.go

* Fixed lint issue

* added testcase for server/api.go UpdateSetting function

* Updated the getMutedUser function to return proper response

* added logs to the new error check

* Added testcase for CheckPluginRequest middleware function

* fixed grammar of error msgs in command.go

* merge master into branch

* review fixes

* updated muted list testcases

Author: Kshitij-Katiyar

server/plugin/command.go

@@ -146,23 +146,28 @@ func (p *Plugin) postCommandResponse(args *model.CommandArgs, text string) {
 	p.client.Post.SendEphemeralPost(args.UserId, post)
 }
 
-func (p *Plugin) getMutedUsernames(userInfo *GitHubUserInfo) []string {
+func (p *Plugin) getMutedUsernames(userInfo *GitHubUserInfo) ([]string, error) {
 	var mutedUsernameBytes []byte
 	err := p.store.Get(userInfo.UserID+"-muted-users", &mutedUsernameBytes)
 	if err != nil {
-		return nil
+		return nil, err
 	}
 	mutedUsernames := string(mutedUsernameBytes)
 	var mutedUsers []string
 	if len(mutedUsernames) == 0 {
-		return mutedUsers
+		return mutedUsers, nil
 	}
 	mutedUsers = strings.Split(mutedUsernames, ",")
-	return mutedUsers
+	return mutedUsers, nil
 }
 
 func (p *Plugin) handleMuteList(_ *model.CommandArgs, userInfo *GitHubUserInfo) string {
-	mutedUsernames := p.getMutedUsernames(userInfo)
+	mutedUsernames, err := p.getMutedUsernames(userInfo)
+	if err != nil {
+		p.client.Log.Error("error occurred getting muted users.", "UserID", userInfo.UserID, "Error", err)
+		return "An error occurred getting muted users. Please try again later"
+	}
+
 	var mutedUsers string
 	for _, user := range mutedUsernames {
 		mutedUsers += fmt.Sprintf("- %v\n", user)
@@ -183,7 +188,12 @@ func contains(s []string, e string) bool {
 }
 
 func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *GitHubUserInfo) string {
-	mutedUsernames := p.getMutedUsernames(userInfo)
+	mutedUsernames, err := p.getMutedUsernames(userInfo)
+	if err != nil {
+		p.client.Log.Error("error occurred getting muted users.", "UserID", userInfo.UserID, "Error", err)
+		return "An error occurred getting muted users. Please try again later"
+	}
+
 	if contains(mutedUsernames, username) {
 		return username + " is already muted"
 	}
@@ -200,7 +210,7 @@ func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *
 		mutedUsers = username
 	}
 
-	_, err := p.store.Set(userInfo.UserID+"-muted-users", []byte(mutedUsers))
+	_, err = p.store.Set(userInfo.UserID+"-muted-users", []byte(mutedUsers))
 	if err != nil {
 		return "Error occurred saving list of muted users"
 	}
@@ -209,11 +219,16 @@ func (p *Plugin) handleMuteAdd(_ *model.CommandArgs, username string, userInfo *
 }
 
 func (p *Plugin) handleUnmute(_ *model.CommandArgs, username string, userInfo *GitHubUserInfo) string {
-	mutedUsernames := p.getMutedUsernames(userInfo)
+	mutedUsernames, err := p.getMutedUsernames(userInfo)
+	if err != nil {
+		p.client.Log.Error("error occurred getting muted users.", "UserID", userInfo.UserID, "Error", err)
+		return "An error occurred getting muted users. Please try again later"
+	}
+
 	userToMute := []string{username}
 	newMutedList := arrayDifference(mutedUsernames, userToMute)
 
-	_, err := p.store.Set(userInfo.UserID+"-muted-users", []byte(strings.Join(newMutedList, ",")))
+	_, err = p.store.Set(userInfo.UserID+"-muted-users", []byte(strings.Join(newMutedList, ",")))
 	if err != nil {
 		return "Error occurred unmuting users"
 	}