Fix linter errors and align golangci-lint config with Jira plugin

- Fix bodyclose errors in client/client_test.go
- Fix misspelling in build/pluginctl/logs.go (configration -> configuration)
- Align golangci-lint config with mattermost-plugin-jira
  - Update goconst.min-len from 2 to 3
  - Remove extra exclude-rules for revive linter

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: wiggin77

.golangci.yml

@@ -6,7 +6,7 @@ run:
 
 linters-settings:
   goconst:
-    min-len: 2
+    min-len: 3
     min-occurrences: 2
   gofmt:
     simplify: true
@@ -115,15 +115,6 @@ issues:
     - path: server/configuration.go
       linters:
         - unused
-    - linters:
-        - revive
-      text: unused-parameter
-    - linters:
-        - revive
-      text: var-naming
-    - linters:
-        - revive
-      text: error-strings
     - path: _test\.go
       linters:
         - bodyclose

build/pluginctl/logs.go

@@ -181,7 +181,7 @@ func checkJSONLogsSetting(ctx context.Context, client *model.Client4) error {
 		return fmt.Errorf("failed to fetch config: %w", err)
 	}
 	if cfg.LogSettings.FileJson == nil || !*cfg.LogSettings.FileJson {
-		return errors.New("JSON output for file logs are disabled. Please enable LogSettings.FileJson via the configration in Mattermost.") //nolint:revive,stylecheck
+		return errors.New("JSON output for file logs are disabled. Please enable LogSettings.FileJson via the configuration in Mattermost.") //nolint:revive,stylecheck
 	}
 
 	return nil

client/client_test.go

@@ -23,14 +23,15 @@ import (
 func TestRoundTripper(t *testing.T) {
 	t.Run("Valid response", func(t *testing.T) {
 		pluginAPI := &plugintest.API{}
-		pluginAPI.On("PluginHTTP", mock.AnythingOfType("*http.Request")).Return(&http.Response{StatusCode: http.StatusOK})
+		pluginAPI.On("PluginHTTP", mock.AnythingOfType("*http.Request")).Return(&http.Response{StatusCode: http.StatusOK, Body: http.NoBody})
 
 		roundTripper := pluginAPIRoundTripper{api: pluginAPI}
 		req, err := http.NewRequest(http.MethodPost, "url", nil)
 		require.NoError(t, err)
 
 		resp, err := roundTripper.RoundTrip(req)
 		require.NoError(t, err)
+		defer resp.Body.Close()
 		require.Equal(t, http.StatusOK, resp.StatusCode)
 	})
 
@@ -44,6 +45,9 @@ func TestRoundTripper(t *testing.T) {
 		require.NoError(t, err)
 
 		resp, err := roundTripper.RoundTrip(req)
+		if resp != nil && resp.Body != nil {
+			defer resp.Body.Close()
+		}
 		require.Nil(t, resp)
 		require.Error(t, err)
 	})