[MM-410]: Fixed the update of Slack attachment props for the meeting post (#411)

* fixed the meeting reconfirmation issue

* fixed testcases

* fix past post fetch to check reconfirmation of meeting

Author: Kshitij-Katiyar

server/http.go

@@ -752,6 +752,10 @@ func (p *Plugin) checkPreviousMessages(channelID string) (recentMeeting bool, me
 	}
 
 	for _, post := range postList.ToSlice() {
+		if post.DeleteAt != 0 {
+			continue
+		}
+
 		meetingProvider := getString("meeting_provider", post.Props)
 		if meetingProvider == "" {
 			continue

server/plugin_test.go

@@ -162,6 +162,7 @@ func TestPlugin(t *testing.T) {
 
 			api.On("KVSetWithOptions", "mutex_mmi_bot_ensure", mock.AnythingOfType("[]uint8"), model.PluginKVSetOptions{Atomic: true, OldValue: []uint8(nil), ExpireInSeconds: 15}).Return(true, nil)
 			api.On("KVSetWithOptions", "mutex_mmi_bot_ensure", []byte(nil), model.PluginKVSetOptions{ExpireInSeconds: 0}).Return(true, nil)
+			api.On("KVSetWithOptions", "post_meeting_234", []byte(nil), model.PluginKVSetOptions{ExpireInSeconds: 0}).Return(true, nil)
 
 			api.On("EnsureBotUser", &model.Bot{
 				Username:    botUserName,

server/store.go

@@ -150,17 +150,17 @@ func (p *Plugin) storeMeetingPostID(meetingID int, postID string) *model.AppErro
 
 func (p *Plugin) fetchMeetingPostID(meetingID string) (string, error) {
 	key := fmt.Sprintf("%v%v", postMeetingKey, meetingID)
-	var postID string
-	if err := p.client.KV.Get(key, &postID); err != nil {
+	var postIDData []byte
+	if err := p.client.KV.Get(key, &postIDData); err != nil {
 		p.client.Log.Debug("Could not get meeting post from KVStore", "error", err.Error())
 		return "", err
 	}
 
-	if postID == "" {
+	if postIDData == nil {
 		return "", errors.New("stored meeting post ID not found")
 	}
 
-	return postID, nil
+	return string(postIDData), nil
 }
 
 func (p *Plugin) deleteMeetingPostID(postID string) error {

server/webhook.go

@@ -69,7 +69,7 @@ func (p *Plugin) handleWebhook(w http.ResponseWriter, r *http.Request) {
 	}
 }
 
-func (p *Plugin) handleMeetingEnded(w http.ResponseWriter, r *http.Request, body []byte) {
+func (p *Plugin) handleMeetingEnded(w http.ResponseWriter, _ *http.Request, body []byte) {
 	var webhook zoom.MeetingWebhook
 	if err := json.Unmarshal(body, &webhook); err != nil {
 		p.client.Log.Error("Error unmarshaling meeting webhook", "err", err.Error())
@@ -169,7 +169,7 @@ func (p *Plugin) verifyZoomWebhookSignature(r *http.Request, body []byte) error
 	return nil
 }
 
-func (p *Plugin) handleValidateZoomWebhook(w http.ResponseWriter, r *http.Request, body []byte) {
+func (p *Plugin) handleValidateZoomWebhook(w http.ResponseWriter, _ *http.Request, body []byte) {
 	config := p.getConfiguration()
 	if config.ZoomWebhookSecret == "" {
 		p.API.LogWarn("Failed to validate Zoom webhook: Zoom webhook secret not set")