optimize log functions (#304)

* move logging to own compilation unit

* remove obsolete (void)0 statements after MO_DBG

* update changelog

* optimize MO_CUSTOM_CONSOLE method

Author: matth-x

CHANGELOG.md

@@ -39,6 +39,7 @@
 - Ignore UnlockConnector when handler not set ([#271](https://github.com/matth-x/MicroOcpp/pull/271))
 - Reject ChargingProfile if unit not supported ([#271](https://github.com/matth-x/MicroOcpp/pull/271))
 - Fix building with debug level warn and error
+- Reduce debug output FW size overhead ([#304](https://github.com/matth-x/MicroOcpp/pull/304))
 - Fix transaction freeze in offline mode ([#279](https://github.com/matth-x/MicroOcpp/pull/279), [#287](https://github.com/matth-x/MicroOcpp/pull/287))
 - Fix compilation error caused by `PRId32` ([#279](https://github.com/matth-x/MicroOcpp/pull/279))
 - Don't load FW-mngt. module when no handlers set ([#271](https://github.com/matth-x/MicroOcpp/pull/271))

CMakeLists.txt

@@ -63,6 +63,7 @@ set(MO_SRC
     src/MicroOcpp/Operations/InstallCertificate.cpp
     src/MicroOcpp/Operations/UnlockConnector.cpp
     src/MicroOcpp/Operations/UpdateFirmware.cpp
+    src/MicroOcpp/Debug.cpp
     src/MicroOcpp/Platform.cpp
     src/MicroOcpp/Core/SimpleRequestFactory.cpp
     src/MicroOcpp/Core/OperationRegistry.cpp

src/MicroOcpp.cpp

@@ -445,7 +445,6 @@ bool endTransaction(const char *idTag, const char *reason, unsigned int connecto
             res = endTransaction_authorized(idTag, reason, connectorId);
         } else {
             MO_DBG_INFO("endTransaction: idTag doesn't match");
-            (void)0;
         }
     }
     return res;
@@ -977,7 +976,6 @@ void setCertificateStore(std::unique_ptr<MicroOcpp::CertificateStore> certStore)
         certService->setCertificateStore(std::move(certStore));
     } else {
         MO_DBG_ERR("OOM");
-        (void)0;
     }
 }
 #endif //MO_ENABLE_CERT_MGMT

src/MicroOcpp/Core/Configuration.cpp

@@ -79,7 +79,6 @@ ConfigurationContainer *declareContainer(const char *filename, bool accessible)
 
     if (container->isAccessible() != accessible) {
         MO_DBG_ERR("%s: conflicting accessibility declarations (expect %s)", filename, container->isAccessible() ? "accessible" : "inaccessible");
-        (void)0;
     }
 
     return container.get();
@@ -95,7 +94,6 @@ std::shared_ptr<Configuration> loadConfiguration(TConfig type, const char *key,
             }
             if (container->isAccessible() != accessible) {
                 MO_DBG_ERR("conflicting accessibility for %s", key);
-                (void)0;
             }
             container->loadStaticKey(*config.get(), key);
             return config;

src/MicroOcpp/Core/ConfigurationContainerFlash.cpp

@@ -181,7 +181,6 @@ class ConfigurationContainerFlash : public ConfigurationContainer {
                 }
             } else {
                 MO_DBG_ERR("OOM: %s", key);
-                (void)0;
             }
         }
 

src/MicroOcpp/Core/FilesystemUtils.cpp

@@ -134,7 +134,6 @@ bool FilesystemUtils::remove_if(std::shared_ptr<FilesystemAdapter> filesystem, s
 
     if (ret != 0) {
         MO_DBG_ERR("ftw_root: %i", ret);
-        (void)0;
     }
 
     return ret == 0;

src/MicroOcpp/Core/FtpMbedTLS.cpp

@@ -411,7 +411,6 @@ void FtpTransferMbedTLS::send_cmd(const char *cmd, const char *arg, bool disable
         MO_DBG_DEBUG("SEND: %s %s", 
                 cmd,
                 !strncmp((char*) cmd, "PASS", strlen("PASS")) ? "***" : arg ? (char*) arg : "");
-        (void)0;
     }
 
     int ret = -1;
@@ -647,7 +646,6 @@ void FtpTransferMbedTLS::process_ctrl() {
             return;
         } else if (!strncmp("200", line, 3)) { //PBSZ -> 0 and PROT -> P accepted
             MO_DBG_INFO("PBSZ/PROT success: %s", line);
-            (void)0;
         } else if (!strncmp("221", line, 3)) { // Server Goodbye
             MO_DBG_DEBUG("closing ctrl connection");
             close_ctrl();

src/MicroOcpp/Core/Request.cpp

@@ -308,7 +308,6 @@ bool Request::restore(std::unique_ptr<StoredOperationHandler> opStorage, Model *
         }
     } else {
         MO_DBG_ERR("cannot set unique msgID counter");
-        (void)0;
         //skip this step but don't abort restore
     }
 
@@ -330,10 +329,8 @@ bool Request::restore(std::unique_ptr<StoredOperationHandler> opStorage, Model *
 
     if (success) {
         MO_DBG_DEBUG("restored opNr %i: %s", opStore->getOpNr(), operation->getOperationType());
-        (void)0;
     } else {
         MO_DBG_ERR("restore opNr %i error", opStore->getOpNr());
-        (void)0;
     }
 
     return success;

src/MicroOcpp/Core/RequestQueue.cpp

@@ -242,10 +242,8 @@ void RequestQueue::receiveResponse(JsonArray json) {
         //didn't find matching Request
         if (json[0] == MESSAGE_TYPE_CALLERROR) {
             MO_DBG_DEBUG("Received CALLERROR did not abort a pending operation");
-            (void)0;
         } else {
             MO_DBG_WARN("Received response doesn't match any pending operation");
-            (void)0;
         }
     }
 }

src/MicroOcpp/Core/RequestQueueStorageStrategy.cpp

@@ -42,7 +42,6 @@ void VolatileRequestQueue::push_back(std::unique_ptr<Request> op) {
 
     if (queue.size() >= MO_OPERATIONCACHE_MAXSIZE) {
         MO_DBG_WARN("unsafe number of cached operations");
-        (void)0;
     }
 
     queue.push_back(std::move(op));