@@ -19,14 +19,6 @@ Evse::Evse(unsigned int connectorId) : connectorId{connectorId} {
1919
2020}
2121
22- MicroOcpp::Connector *getConnector (unsigned int connectorId) {
23- if (!getOcppContext ()) {
24- MO_DBG_ERR (" unitialized" );
25- return nullptr ;
26- }
27- return getOcppContext ()->getModel ().getConnector (connectorId);
28- }
29-
3022void Evse::setup () {
3123
3224#if MO_ENABLE_V201
@@ -43,12 +35,6 @@ void Evse::setup() {
4335 }
4436#endif
4537
46- auto connector = getConnector (connectorId);
47- if (!connector) {
48- MO_DBG_ERR (" invalid state" );
49- return ;
50- }
51-
5238 char key [30 ] = {' \0 ' };
5339
5440 snprintf (key, 30 , " evPlugged_cId_%u" , connectorId);
@@ -134,12 +120,11 @@ void Evse::setup() {
134120}
135121
136122void Evse::loop () {
137- if (auto connector = getConnector (connectorId)) {
138- auto curStatus = connector->getStatus ();
139123
140- if (status.compare (MicroOcpp::cstrFromOcppEveState (curStatus))) {
141- status = MicroOcpp::cstrFromOcppEveState (curStatus);
142- }
124+ auto curStatus = getChargePointStatus (connectorId);
125+
126+ if (status.compare (MicroOcpp::cstrFromOcppEveState (curStatus))) {
127+ status = MicroOcpp::cstrFromOcppEveState (curStatus);
143128 }
144129
145130 bool simulate_isCharging = ocppPermitsCharge (connectorId) && trackEvPluggedBool->getBool () && trackEvsePluggedBool->getBool () && trackEvReadyBool->getBool () && trackEvseReadyBool->getBool ();
@@ -167,21 +152,16 @@ void Evse::presentNfcTag(const char *uid_cstr) {
167152 return ;
168153 }
169154 std::string uid = uid_cstr;
170- auto connector = getConnector (connectorId);
171- if (!connector) {
172- MO_DBG_ERR (" invalid state" );
173- return ;
174- }
175155
176156#if MO_ENABLE_V201
177157 if (auto context = getOcppContext ()) {
178158 if (context->getVersion ().major == 2 ) {
179159 if (auto txService = context->getModel ().getTransactionService ()) {
180160 if (auto evse = txService->getEvse (connectorId)) {
181- if (evse->getTransaction () && evse->getTransaction ()->isAuthorized ) {
182- evse->endAuthorization (uid_cstr);
161+ if (evse->getTransaction () && evse->getTransaction ()->isAuthorizationActive ) {
162+ evse->endAuthorization (MicroOcpp::IdToken ( uid_cstr, MicroOcpp::IdToken::Type::KeyCode) );
183163 } else {
184- evse->beginAuthorization (uid_cstr);
164+ evse->beginAuthorization (MicroOcpp::IdToken ( uid_cstr, MicroOcpp::IdToken::Type::KeyCode) );
185165 }
186166 return ;
187167 }
@@ -190,14 +170,14 @@ void Evse::presentNfcTag(const char *uid_cstr) {
190170 }
191171#endif
192172
193- if (connector-> getTransaction () && connector-> getTransaction ()-> isActive ( )) {
194- if (!uid.compare (connector-> getTransaction ()-> getIdTag ( ))) {
195- connector-> endTransaction (uid.c_str ());
173+ if (isTransactionActive (connectorId )) {
174+ if (!uid.compare (getTransactionIdTag (connectorId ))) {
175+ endTransaction (uid.c_str (), " Local " , connectorId );
196176 } else {
197177 MO_DBG_INFO (" RFID card denied" );
198178 }
199179 } else {
200- connector-> beginTransaction (uid.c_str ());
180+ beginTransaction (uid.c_str (), connectorId );
201181 }
202182}
203183
@@ -246,30 +226,15 @@ bool Evse::getEvseReady() {
246226}
247227
248228const char *Evse::getSessionIdTag () {
249- auto connector = getConnector (connectorId);
250- if (!connector) {
251- MO_DBG_ERR (" invalid state" );
252- return nullptr ;
253- }
254- return connector->getTransaction () ? connector->getTransaction ()->getIdTag () : nullptr ;
229+ return getTransactionIdTag (connectorId) ? getTransactionIdTag (connectorId) : " " ;
255230}
256231
257232int Evse::getTransactionId () {
258- auto connector = getConnector (connectorId);
259- if (!connector) {
260- MO_DBG_ERR (" invalid state" );
261- return -1 ;
262- }
263- return connector->getTransaction () ? connector->getTransaction ()->getTransactionId () : -1 ;
233+ return getTransaction (connectorId) ? getTransaction (connectorId)->getTransactionId () : -1 ;
264234}
265235
266236bool Evse::chargingPermitted () {
267- auto connector = getConnector (connectorId);
268- if (!connector) {
269- MO_DBG_ERR (" invalid state" );
270- return false ;
271- }
272- return connector->ocppPermitsCharge ();
237+ return ocppPermitsCharge (connectorId);
273238}
274239
275240int Evse::getPower () {
0 commit comments