@@ -19,14 +19,6 @@ Evse::Evse(unsigned int connectorId) : connectorId{connectorId} {
1919
2020}
2121
22- MicroOcpp::Connector *getConnector (unsigned int connectorId) {
23- if (!getOcppContext ()) {
24- MO_DBG_ERR (" unitialized" );
25- return nullptr ;
26- }
27- return getOcppContext ()->getModel ().getConnector (connectorId);
28- }
29-
3022void Evse::setup () {
3123
3224#if MO_ENABLE_V201
@@ -43,12 +35,6 @@ void Evse::setup() {
4335 }
4436#endif
4537
46- auto connector = getConnector (connectorId);
47- if (!connector) {
48- MO_DBG_ERR (" invalid state" );
49- return ;
50- }
51-
5238 char key [30 ] = {' \0 ' };
5339
5440 snprintf (key, 30 , " evPlugged_cId_%u" , connectorId);
@@ -131,12 +117,11 @@ void Evse::setup() {
131117}
132118
133119void Evse::loop () {
134- if (auto connector = getConnector (connectorId)) {
135- auto curStatus = connector->getStatus ();
136120
137- if (status.compare (MicroOcpp::cstrFromOcppEveState (curStatus))) {
138- status = MicroOcpp::cstrFromOcppEveState (curStatus);
139- }
121+ auto curStatus = getChargePointStatus (connectorId);
122+
123+ if (status.compare (MicroOcpp::cstrFromOcppEveState (curStatus))) {
124+ status = MicroOcpp::cstrFromOcppEveState (curStatus);
140125 }
141126
142127 bool simulate_isCharging = ocppPermitsCharge (connectorId) && trackEvPluggedBool->getBool () && trackEvReadyBool->getBool () && trackEvseReadyBool->getBool ();
@@ -164,11 +149,6 @@ void Evse::presentNfcTag(const char *uid_cstr) {
164149 return ;
165150 }
166151 std::string uid = uid_cstr;
167- auto connector = getConnector (connectorId);
168- if (!connector) {
169- MO_DBG_ERR (" invalid state" );
170- return ;
171- }
172152
173153#if MO_ENABLE_V201
174154 if (auto context = getOcppContext ()) {
@@ -178,7 +158,7 @@ void Evse::presentNfcTag(const char *uid_cstr) {
178158 if (evse->getTransaction () && evse->getTransaction ()->isAuthorized ) {
179159 evse->endAuthorization (uid_cstr);
180160 } else {
181- evse->beginAuthorization (uid_cstr);
161+ evse->beginAuthorization (MicroOcpp::IdToken ( uid_cstr, MicroOcpp::IdToken::Type::KeyCode) );
182162 }
183163 return ;
184164 }
@@ -187,14 +167,14 @@ void Evse::presentNfcTag(const char *uid_cstr) {
187167 }
188168#endif
189169
190- if (connector-> getTransaction () && connector-> getTransaction ()-> isActive ( )) {
191- if (!uid.compare (connector-> getTransaction ()-> getIdTag ( ))) {
192- connector-> endTransaction (uid.c_str ());
170+ if (isTransactionActive (connectorId )) {
171+ if (!uid.compare (getTransactionIdTag (connectorId ))) {
172+ endTransaction (uid.c_str (), " Local " , connectorId );
193173 } else {
194174 MO_DBG_INFO (" RFID card denied" );
195175 }
196176 } else {
197- connector-> beginTransaction (uid.c_str ());
177+ beginTransaction (uid.c_str (), connectorId );
198178 }
199179}
200180
@@ -232,30 +212,15 @@ bool Evse::getEvseReady() {
232212}
233213
234214const char *Evse::getSessionIdTag () {
235- auto connector = getConnector (connectorId);
236- if (!connector) {
237- MO_DBG_ERR (" invalid state" );
238- return nullptr ;
239- }
240- return connector->getTransaction () ? connector->getTransaction ()->getIdTag () : nullptr ;
215+ return getTransactionIdTag (connectorId) ? getTransactionIdTag (connectorId) : " " ;
241216}
242217
243218int Evse::getTransactionId () {
244- auto connector = getConnector (connectorId);
245- if (!connector) {
246- MO_DBG_ERR (" invalid state" );
247- return -1 ;
248- }
249- return connector->getTransaction () ? connector->getTransaction ()->getTransactionId () : -1 ;
219+ return getTransaction (connectorId) ? getTransaction (connectorId)->getTransactionId () : -1 ;
250220}
251221
252222bool Evse::chargingPermitted () {
253- auto connector = getConnector (connectorId);
254- if (!connector) {
255- MO_DBG_ERR (" invalid state" );
256- return false ;
257- }
258- return connector->ocppPermitsCharge ();
223+ return ocppPermitsCharge (connectorId);
259224}
260225
261226int Evse::getPower () {
0 commit comments