ST0008: orthogonalising output styling and formatting

Author: matthewsinclair

lib/arca_cli/output.ex

@@ -181,4 +181,4 @@ defmodule Arca.Cli.Output do
       _ -> determine_style(%Ctx{})
     end
   end
-end
+end

lib/arca_cli/output/fancy_renderer.ex

@@ -76,8 +76,10 @@ defmodule Arca.Cli.Output.FancyRenderer do
         output
         |> Enum.map(&render_item/1)
         |> Enum.join("\n")
+
       nil ->
         ""
+
       _ ->
         # Fallback for non-list output
         safe_to_string(ctx.output)
@@ -111,7 +113,9 @@ defmodule Arca.Cli.Output.FancyRenderer do
   defp render_item({:table, rows, opts}) do
     # Handle empty tables gracefully
     case rows do
-      [] -> ""
+      [] ->
+        ""
+
       [_ | _] ->
         table_opts =
           Keyword.merge(

lib/arca_cli/output/plain_renderer.ex

@@ -69,8 +69,10 @@ defmodule Arca.Cli.Output.PlainRenderer do
           |> Enum.map(&render_item/1)
           |> Enum.reject(&is_nil/1)
           |> Enum.intersperse("\n")
+
         nil ->
           []
+
         other ->
           # Fallback for non-list output
           [safe_to_string(other)]

test/arca_cli/output_test.exs

@@ -38,6 +38,7 @@ defmodule Arca.Cli.OutputTest do
           {:warning, "Check logs"}
         ]
       }
+
       result = Output.render(ctx)
       assert result =~ "Starting"
       assert result =~ "Done"
@@ -75,7 +76,8 @@ defmodule Arca.Cli.OutputTest do
 
     test "respects NO_COLOR environment variable" do
       System.put_env("NO_COLOR", "1")
-      System.put_env("TERM", "xterm-256color")  # Would normally trigger fancy
+      # Would normally trigger fancy
+      System.put_env("TERM", "xterm-256color")
 
       assert Output.current_style() == :plain
     end
@@ -178,6 +180,7 @@ defmodule Arca.Cli.OutputTest do
         output: [{:success, "Test"}],
         meta: %{style: :fancy}
       }
+
       result = Output.render(ctx)
 
       # Fancy renderer should include colors if properly mocked
@@ -190,6 +193,7 @@ defmodule Arca.Cli.OutputTest do
         output: [{:success, "Test"}],
         meta: %{style: :plain}
       }
+
       result = Output.render(ctx)
 
       # Plain renderer returns iodata, should be converted to binary
@@ -202,6 +206,7 @@ defmodule Arca.Cli.OutputTest do
       ctx = %Ctx{
         output: [{:table, [%{name: "Alice", age: 30}], []}]
       }
+
       result = Output.render(ctx)
 
       assert result =~ "Alice"
@@ -212,6 +217,7 @@ defmodule Arca.Cli.OutputTest do
       ctx = %Ctx{
         output: [{:list, ["Item 1", "Item 2"], title: "Items"}]
       }
+
       result = Output.render(ctx)
 
       assert result =~ "Item 1"
@@ -308,4 +314,4 @@ defmodule Arca.Cli.OutputTest do
   # Helper to restore environment variables
   defp restore_env(key, nil), do: System.delete_env(key)
   defp restore_env(key, value), do: System.put_env(key, value)
-end
+end