Always run playwright tests, more expensive but just makes sense to check all versions

Author: matthiask

.github/workflows/playwright.yml

@@ -27,7 +27,13 @@ jobs:
         python-version: ${{ matrix.python-version }}
     - name: Install dependencies
       run: |
-        python -m pip install --upgrade pip tox
+        python -m pip install --upgrade pip tox pytest-playwright
+
+    # Install playwright system dependencies
+    - name: Install Playwright browsers
+      run: |
+        playwright install --with-deps chromium
+
     - name: Run tox targets for ${{ matrix.python-version }}
       run: |
         ENV_PREFIX=$(tr -C -d "0-9" <<< "${{ matrix.python-version }}")

.github/workflows/tests.yml

@@ -0,0 +1,46 @@
+import os
+
+import pytest
+
+
+@pytest.fixture(scope="function")
+def browser_context_args(browser_context_args):
+    """Modify browser context arguments for tracing."""
+    return {
+        **browser_context_args,
+        "record_video_dir": os.path.join(os.getcwd(), "test-results/videos/"),
+        "record_har_path": os.path.join(os.getcwd(), "test-results/har/", "test.har"),
+    }
+
+
+@pytest.hookimpl(hookwrapper=True)
+def pytest_runtest_makereport(item, call):
+    """Handle reporting and artifact generation."""
+    outcome = yield
+    report = outcome.get_result()
+
+    # Take screenshot of failed tests
+    if report.when == "call" and report.failed:
+        try:
+            page = item.funcargs["page"]
+            # Take screenshot and save it with test name
+            screenshot_dir = os.path.join(os.getcwd(), "screenshots")
+            os.makedirs(screenshot_dir, exist_ok=True)
+            screenshot_path = os.path.join(screenshot_dir, f"{item.name}_failed.png")
+            page.screenshot(path=screenshot_path)
+            # Save page HTML
+            html_path = os.path.join(screenshot_dir, f"{item.name}_failed.html")
+            with open(html_path, "w", encoding="utf-8") as f:
+                f.write(page.content())
+
+            # Add to report
+            report.extra = [
+                {
+                    "name": "Screenshot",
+                    "content": screenshot_path,
+                    "mime_type": "image/png",
+                },
+                {"name": "HTML", "content": html_path, "mime_type": "text/html"},
+            ]
+        except Exception as e:
+            print(f"Failed to capture artifacts: {e}")

tests/conftest.py

@@ -1,31 +1,17 @@
-import importlib.util
 import os
 
 import pytest
+from playwright.sync_api import expect
 
 from testapp.models import ProseEditorModel
 
 
-# Check if playwright is installed
-playwright_available = importlib.util.find_spec("playwright") is not None
-
-# Only import playwright modules if available
-if playwright_available:
-    from playwright.sync_api import expect
-
-
 # Set Django async unsafe to allow database operations in tests
 os.environ.setdefault("DJANGO_ALLOW_ASYNC_UNSAFE", "true")
 
-# Skip reason for when playwright is not available
-requires_playwright = pytest.mark.skipif(
-    not playwright_available, reason="Playwright not installed, skipping browser tests"
-)
-
 
 @pytest.mark.django_db
 @pytest.mark.e2e
-@requires_playwright
 def test_prose_editor_admin_form(page, live_server):
     """Test that the prose editor loads and works in the admin."""
     # Login first
@@ -76,7 +62,6 @@ def test_prose_editor_admin_form(page, live_server):
 
 @pytest.mark.django_db
 @pytest.mark.e2e
-@requires_playwright
 def test_prose_editor_formatting(page, live_server):
     """Test formatting functionality in the prose editor."""
     # Login first

tests/testapp/test_prose_editor_e2e.py

@@ -6,8 +6,14 @@ envlist =
 [testenv]
 usedevelop = true
 extras = all,tests
+passenv =
+    HOME
+    PYTHONPATH
+    DISPLAY
+    XAUTHORITY
 commands =
-    pytest --cov=django_prose_editor --cov-report=term-missing tests/testapp {posargs}
+    playwright install --with-deps chromium
+    pytest --cov=django_prose_editor --cov-report=term-missing --browser chromium tests/testapp {posargs}
     coverage report -m
 deps =
     dj42: Django>=4.2,<5.0
@@ -16,17 +22,7 @@ deps =
     dj52: Django>=5.2a1,<6.0
     djmain: https://github.com/django/django/archive/main.tar.gz
 
-[testenv:playwright]
-usedevelop = true
-extras = all,tests
-passenv =
-    HOME
-    PYTHONPATH
-    DISPLAY
-    XAUTHORITY
-commands =
-    playwright install chromium
-    pytest tests/testapp/test_prose_editor_e2e.py -v --browser chromium
+# The default testenv now includes Playwright
 
 [testenv:docs]
 deps =