Make everything work with Symfony 5

Not sure yet if it also works with older versions.

Author: matthiasnoback

.travis.yml

@@ -16,7 +16,8 @@ before_install:
     composer require --dev --no-update symfony/validator "$SYMFONY_VERSION" &&
     composer require --dev --no-update symfony/form "$SYMFONY_VERSION" &&
     composer require --dev --no-update symfony/yaml "$SYMFONY_VERSION" &&
-    composer require --dev --no-update symfony/finder "$SYMFONY_VERSION"
+    composer require --dev --no-update symfony/finder "$SYMFONY_VERSION" &&
+    composer require --dev --no-update symfony/translation "$SYMFONY_VERSION"
 
 install:
   - composer update --prefer-dist

composer.json

@@ -23,19 +23,20 @@
         }
     },
     "require": {
-        "php": ">=7.0",
+        "php": ">=7.1",
         "symfony/form": "~3.4|~4.0|~5.0",
         "symfony/console": "~3.4|~4.0|~5.0",
         "symfony/translation": "~3.4|~4.0|~5.0"
     },
     "require-dev": {
         "beberlei/assert": "~2.1",
-        "behat/behat": "~3.0",
+        "behat/behat": "^3.6",
         "friendsofphp/php-cs-fixer": "^1.10|^2.2",
         "symfony/finder": "~3.4|~4.0|~5.0",
         "symfony/framework-bundle": "~3.4|~4.0|~5.0",
         "symfony/validator": "~3.4|~4.0|~5.0",
         "symfony/yaml": "~3.4|~4.0|~5.0",
-        "symfony/security": "~3.4|~4.0|~5.0"
+        "symfony/security": "~3.4|~4.0|~5.0",
+        "phpunit/phpunit": "^7"
     }
 }

features/bootstrap/FeatureContext.php

@@ -1,13 +1,14 @@
 <?php
 
-use Assert\Assertion;
 use Behat\Behat\Context\Context;
 use Behat\Behat\Context\SnippetAcceptingContext;
 use Behat\Gherkin\Node\PyStringNode;
+use Behat\Gherkin\Node\TableNode;
 use Matthias\SymfonyConsoleForm\Tests\AppKernel;
-use Matthias\SymfonyConsoleForm\Tests\Helper\ApplicationTester;
 use Matthias\SymfonyConsoleForm\Tests\Helper\StringUtil;
+use PHPUnit\Framework\Assert;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Symfony\Component\Console\Tester\ApplicationTester;
 
 /**
  * Defines application features from the specific context.
@@ -37,15 +38,17 @@ public function __construct()
 
         $kernel = new AppKernel('test', true);
         $this->application = new Application($kernel);
+        $this->application->setAutoExit(false);
         $this->tester = new ApplicationTester($this->application);
     }
 
     /**
      * @Given /^I run the command "([^"]*)" and I provide as input$/
      */
-    public function iRunTheCommandAndIProvideAsInput($name, PyStringNode $input)
+    public function iRunTheCommandAndIProvideAsInput($name, TableNode $input)
     {
-        $this->runCommandWithInteractiveInput($name, $input);
+        $inputs = array_column($input->getHash(), 'Input');
+        $this->runCommandWithInteractiveInput($name, $inputs);
     }
 
     /**
@@ -61,33 +64,38 @@ public function iRunTheCommandAndIProvideAsInputOneLine($name, $input)
      */
     public function theOutputShouldBe(PyStringNode $expectedOutput)
     {
-        Assertion::same(
-            StringUtil::trimLines($this->getOutput()),
-            StringUtil::trimLines((string) $expectedOutput)
+        Assert::assertEquals(
+            StringUtil::trimLines((string) $expectedOutput),
+            StringUtil::trimLines($this->getOutput())
         );
     }
 
-    private function runCommandWithInteractiveInput($name, $input)
+    private function runCommandWithInteractiveInput($name, array $inputs)
     {
-        $input = str_replace('[enter]', "\n", $input);
-        $this->tester->putToInputStream($input);
-        $this->tester->run($name, array('interactive' => true, 'decorated' => false));
+        $this->tester->setInputs($inputs);
+        $this->tester->run(['command' => $name], array('interactive' => true, 'decorated' => false));
     }
 
     /**
      * @Then /^the output should contain$/
      */
     public function theOutputShouldContain(PyStringNode $expectedOutput)
     {
-        Assertion::contains(StringUtil::trimLines($this->getOutput()), StringUtil::trimLines((string) $expectedOutput));
+        Assert::assertStringContainsString(
+            StringUtil::trimLines((string) $expectedOutput),
+            StringUtil::trimLines($this->getOutput())
+        );
     }
 
     /**
      * @Then /^the output should not contain$/
      */
     public function theOutputShouldNotContain(PyStringNode $expectedOutput)
     {
-        Assertion::false(strpos(StringUtil::trimLines($this->getOutput()), StringUtil::trimLines((string) $expectedOutput)));
+        Assert::assertStringNotContainsString(
+            StringUtil::trimLines($this->getOutput()),
+            StringUtil::trimLines((string) $expectedOutput)
+        );
     }
 
     private function getOutput()
@@ -100,27 +108,34 @@ private function getOutput()
      */
     public function theCommandHasFinishedSuccessfully()
     {
-        Assertion::same($this->tester->getStatusCode(), 0);
+        Assert::assertEquals(0, $this->tester->getStatusCode());
     }
 
     /**
      * @Then /^the command was not successful$/
      */
     public function theCommandWasNotSuccessful()
     {
-        Assertion::notSame($this->tester->getStatusCode(), 0);
+        Assert::assertNotEquals(0, $this->tester->getStatusCode());
     }
 
     /**
-     * @When /^I run the command "([^"]*)" non\-interactively$/
+     * @When /^I run a command non-interactively with parameters$/
      */
-    public function iRunTheCommandNonInteractively($command)
+    public function iRunTheCommandNonInteractively(TableNode $parameters)
     {
-        $this->runCommandWithNonInteractiveInput($command);
+        $parameters = $parameters->getHash();
+
+        $input = array_combine(
+            array_column($parameters, 'Parameter'),
+            array_column($parameters, 'Value')
+        );
+
+        $this->runCommandWithNonInteractiveInput($input);
     }
 
-    private function runCommandWithNonInteractiveInput($name)
+    private function runCommandWithNonInteractiveInput(array $input)
     {
-        $this->tester->run($name, array('interactive' => false, 'decorated' => false));
+        $this->tester->run($input, array('interactive' => false, 'decorated' => false));
     }
 }