Adjust ECS

Author: matthiasnoback

ecs.php

@@ -27,6 +27,4 @@
 
     $containerConfigurator->import(SetList::CONTROL_STRUCTURES);
     $containerConfigurator->import(SetList::PSR_12);
-    $containerConfigurator->import(SetList::COMMON);
-    $containerConfigurator->import(SetList::SYMPLIFY);
 };

src/Bridge/Transformer/AbstractTextInputBasedTransformer.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Matthias\SymfonyConsoleForm\Bridge\Transformer;

src/Bridge/Transformer/IntegerTransformer.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Matthias\SymfonyConsoleForm\Bridge\Transformer;

src/Bridge/Transformer/NumberTransformer.php

@@ -1,4 +1,5 @@
 <?php
+
 declare(strict_types=1);
 
 namespace Matthias\SymfonyConsoleForm\Bridge\Transformer;

src/Console/Command/DynamicFormBasedCommand.php

@@ -29,6 +29,6 @@ public function formType(): string
 
     protected function configure(): void
     {
-        $this->setName('form:'.$this->commandName);
+        $this->setName('form:' . $this->commandName);
     }
 }

src/Console/Command/FormBasedCommandCapabilities.php

@@ -11,6 +11,14 @@ trait FormBasedCommandCapabilities
      */
     private $formData;
 
+    /**
+     * @param mixed $data
+     */
+    public function setFormData($data): void
+    {
+        $this->formData = $data;
+    }
+
     /**
      * @return mixed
      */
@@ -28,12 +36,4 @@ protected function formData()
 
         return $this->formData;
     }
-
-    /**
-     * @param mixed $data
-     */
-    public function setFormData($data): void
-    {
-        $this->formData = $data;
-    }
 }

src/Console/Command/FormBasedCommandWithDefault.php

@@ -1,4 +1,6 @@
-<?php declare(strict_types = 1);
+<?php
+
+declare(strict_types=1);
 
 namespace Matthias\SymfonyConsoleForm\Console\Command;
 

src/Console/EventListener/RegisterHelpersEventListener.php

@@ -22,7 +22,7 @@ public function onConsoleCommand(ConsoleCommandEvent $event): void
     {
         $command = $event->getCommand();
 
-        if (null === $command) {
+        if ($command === null) {
             throw new RuntimeException('Received ConsoleCommandEvent without Command instance!');
         }
 

src/Console/Helper/FormHelper.php

@@ -18,11 +18,6 @@ final class FormHelper extends Helper
     private $formFactory;
     private $formInteractor;
 
-    public function getName(): string
-    {
-        return 'form';
-    }
-
     public function __construct(
         ConsoleFormFactory $formFactory,
         FormInteractor $formInteractor
@@ -31,6 +26,11 @@ public function __construct(
         $this->formInteractor = $formInteractor;
     }
 
+    public function getName(): string
+    {
+        return 'form';
+    }
+
     /**
      * @param mixed $data
      *
@@ -66,7 +66,7 @@ public function interactUsingForm(
                 $output->write(sprintf('Invalid data provided: %s', $formErrors));
                 if ($this->noErrorsCanBeFixed($formErrors)) {
                     $violationPaths = $this->constraintViolationPaths($formErrors);
-                    $hint = (count($violationPaths) > 0 ? ' (Violations on unused fields: '.implode(', ', $violationPaths).')' : '');
+                    $hint = (count($violationPaths) > 0 ? ' (Violations on unused fields: ' . implode(', ', $violationPaths) . ')' : '');
                     throw new RuntimeException(
                         'Errors out of the form\'s scope - do you have validation constraints on properties not used in the form?'
                         . $hint
@@ -94,9 +94,9 @@ protected function noErrorsCanBeFixed(FormErrorIterator $errors): bool
     {
         // none of the remaining errors is related to a value of a form field
         return $errors->count() > 0 &&
-            0 === count(array_filter(iterator_to_array($errors), function ($error) {
+            count(array_filter(iterator_to_array($errors), function ($error) {
                 return $error instanceof FormErrorIterator;
-            }));
+            })) === 0;
     }
 
     protected function constraintViolationPaths(FormErrorIterator $errors): array

src/Console/Helper/Question/AlwaysReturnKeyOfChoiceQuestion.php

@@ -170,6 +170,6 @@ private function assertFlatChoiceViewsArray(array $choiceViews)
      */
     private function canBeConvertedToString($value)
     {
-        return null === $value || is_scalar($value) || (\is_object($value) && method_exists($value, '__toString'));
+        return $value === null || is_scalar($value) || (\is_object($value) && method_exists($value, '__toString'));
     }
 }