check for conversion possibility, don't rely on exception catching

Author: igneus

src/Console/Helper/Question/AlwaysReturnKeyOfChoiceQuestion.php

@@ -117,12 +117,9 @@ private function prepareChoices()
         $choices = [];
         foreach ($this->choiceViews as $choiceView) {
             $label = $choiceView->label;
-            if ($choiceView->data != $choiceView->value) {
-                try {
-                    $label .= ' (<comment>' . $choiceView->data . '</comment>)';
-                } catch (\ErrorException $exception) {
-                    // data cannot be converted to string - do nothing
-                }
+            $data = $choiceView->data;
+            if ($data != $choiceView->value && $this->canBeConvertedToString($data)) {
+                $label .= ' (<comment>' . $data . '</comment>)';
             }
 
             $choices[$choiceView->value] = $label;
@@ -140,11 +137,12 @@ private function prepareAutocompleteValues()
 
         foreach ($this->choiceViews as $choiceView) {
             $autocompleteValues[] = $choiceView->value;
-            try {
-                $autocompleteValues[] = (string)$choiceView->data;
-            } catch (\ErrorException $exception) {
-                // data cannot be converted to string - do nothing
+
+            $data = $choiceView->data;
+            if ($this->canBeConvertedToString($data)) {
+                $autocompleteValues[] = (string)$data;
             }
+
             $autocompleteValues[] = $choiceView->label;
         }
 
@@ -164,4 +162,13 @@ private function assertFlatChoiceViewsArray(array $choiceViews)
             }
         }
     }
+
+    /**
+     * @param mixed $value
+     * @return bool
+     */
+    private function canBeConvertedToString($value)
+    {
+        return null === $value || is_scalar($value) || (\is_object($value) && method_exists($value, '__toString'));
+    }
 }