Skip to content

Commit f6ba76b

Browse files
authored
Build using .net core 3.0 (#5)
* Build using .net core 3.0 * Only build master branch * Make sure to build .net core 2 and 3 tools * Fix the tests for new APIs
1 parent 8f6c1c3 commit f6ba76b

File tree

7 files changed

+30
-280
lines changed

7 files changed

+30
-280
lines changed

.appveyor.yml

Lines changed: 0 additions & 10 deletions
This file was deleted.

Mono.ApiTools.NuGetDiff.Tests/PackageComparerTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -422,6 +422,10 @@ public async Task TestMatchPortableUpgradeToNetStandard()
422422
Assert.Equal("lib/portable-net45+win8+wpa81+wp8/SkiaSharp.dll", xStdAss.Attribute("old_path").Value);
423423
var netStdFile = File.ReadAllText(Path.Combine(diffDir, "netstandard1.3", "SkiaSharp.dll.diff.md"));
424424
var netFile = File.ReadAllText(Path.Combine(diffDir, "net45", "SkiaSharp.dll.diff.md"));
425+
426+
// replace the new .NET Standard type
427+
netFile = netFile.Replace("System.IAsyncDisposable, System.IDisposable", "System.IDisposable");
428+
425429
Assert.Equal(netStdFile, netFile);
426430
}
427431

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ point to diff a NuGet package:
1414
## Building
1515

1616
This project is very simple and can be built, packed and tested using
17-
`msbuild` and `dotnet`. But, to do everything in a single step, there is
18-
a cake script:
17+
`msbuild` and `dotnet`. But, to do everything in a single step, there
18+
is the .NET Core Cake tool ([`Cake.Tool`](https://www.nuget.org/packages/Cake.Tool)):
1919

2020
```
21-
.\build.ps1
21+
dotnet cake
2222
```
2323

2424
## Using

api-tools/api-tools.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<PropertyGroup>
44
<OutputType>Exe</OutputType>
5-
<TargetFrameworks>netcoreapp2.2</TargetFrameworks>
5+
<TargetFrameworks>netcoreapp2.1;netcoreapp2.2;netcoreapp3.0</TargetFrameworks>
66
<LangVersion>latest</LangVersion>
77
<RootNamespace>Mono.ApiTools</RootNamespace>
88
<AssemblyName>api-tools</AssemblyName>

azure-pipelines.yml

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,26 @@
1+
trigger:
2+
- master
3+
14
pool:
2-
vmImage: 'windows-latest'
5+
name: 'Hosted Windows 2019 with VS2019'
36

47
variables:
5-
BUILD_NUMBER: $[counter('$(Build.SourceBranchName)_counter', 1)]
8+
BASE_VERSION: 1.1.0
9+
BUILD_NUMBER: $[counter(format('{0}_{1}', variables['BASE_VERSION'], variables['Build.SourceBranch']), 1)]
10+
PACKAGE_VERSION: $(BASE_VERSION).$(BUILD_NUMBER)
611
CONFIGURATION: 'Release'
7-
PACKAGE_VERSION: '1.0.2.$(BUILD_NUMBER)'
8-
# BUILD_PRERELEASE: [true|false]
12+
BUILD_PRERELEASE: true
13+
CAKE_VERSION: 0.35.0
14+
DOTNET_CORE_VERSION: 3.0.x
915

1016
steps:
11-
- powershell: .\build.ps1 --configuration="$(CONFIGURATION)" --packageVersion="$(PACKAGE_VERSION)"
17+
- task: UseDotNet@2
18+
inputs:
19+
version: $(DOTNET_CORE_VERSION)
20+
performMultiLevelLookup: true
21+
- powershell: |
22+
dotnet tool install -g cake.tool --version $(CAKE_VERSION)
23+
- powershell: dotnet cake --configuration="$(CONFIGURATION)" --packageVersion="$(PACKAGE_VERSION)" --prerelease="$(BUILD_PRERELEASE)"
1224
- task: PublishBuildArtifacts@1
1325
inputs:
1426
PathToPublish: output

build.cake

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
var target = Argument("target", "Default");
22
var configuration = Argument("configuration", "Release");
3-
var prerelease = bool.Parse (Argument("prerelease", EnvironmentVariable ("BUILD_PRERELEASE") ?? "true"));
3+
var prerelease = Argument("prerelease", true);
44

55
// a bit of logic to create the version number:
66
// - input = 1.2.3.4
77
// - package version = 1.2.3
8-
// - preview package version = 1.2.3-preview-4
9-
var version = Version.Parse(Argument("packageversion", EnvironmentVariable("BUILD_BUILDNUMBER") ?? EnvironmentVariable("APPVEYOR_BUILD_VERSION") ?? "1.0.0.0"));
8+
// - preview package version = 1.2.3-preview.4
9+
var version = Version.Parse(Argument("packageversion", "1.0.0.0"));
1010
var previewNumber = version.Revision;
1111
var assemblyVersion = $"{version.Major}.0.0.0";
1212
var fileVersion = $"{version.Major}.{version.Minor}.{version.Build}.0";
1313
var infoVersion = $"{version.Major}.{version.Minor}.{version.Build}.{version.Revision}";
1414
var packageVersion = $"{version.Major}.{version.Minor}.{version.Build}";
15-
var previewVersion = packageVersion + "-preview." + previewNumber;
15+
var previewVersion = packageVersion + "-preview." + previewNumber;
1616

1717
Task("Build")
1818
.Does(() =>
@@ -65,7 +65,7 @@ Task("Test")
6565
});
6666

6767
Information("Running app tests...");
68-
var app = $"api-tools/bin/{configuration}/netcoreapp2.2/api-tools.dll";
68+
var app = $"api-tools/bin/{configuration}/netcoreapp3.0/api-tools.dll";
6969
var id = "Mono.ApiTools.NuGetDiff";
7070
var version = prerelease ? previewVersion : packageVersion;
7171
DotNetCoreExecute(app, $"nuget-diff ./output/{id}.{version}.nupkg --latest --cache=externals --output=test-output");

build.ps1

Lines changed: 0 additions & 256 deletions
This file was deleted.

0 commit comments

Comments
 (0)