Skip to content

Commit a08c934

Browse files
committed
fix env example and ci file
1 parent f8788fe commit a08c934

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.env.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
A_AUDIENCE="audience-in-oidc-request"
1+
ALLOWED_AUDIENCE="audience-in-oidc-request"
22
GITHUB_APP_NAME="GitHub App Name"
33
GITHUB_APP_CLIENT_ID="your-app-client-id"
44
GITHUB_APP_PRIVATE_KEY="-----BEGIN RSA PRIVATE KEY-----

.github/workflows/ci.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: Integration test
4646
run: |
4747
# Start service in background
48-
uv run fastapi dev app/main.py --port 8000 &
48+
uv run fastapi run --port 8000 &
4949
sleep 5
5050
5151
# Get OIDC token and test the endpoint
@@ -56,8 +56,7 @@ jobs:
5656
-d "{\"oidc_token\": \"$TOKEN\"}" \
5757
http://localhost:8000/github/github-app-token-exchange
5858
env:
59-
GITHUB_APP_ID: ${{ secrets.GITHUB_APP_ID }}
60-
GITHUB_APP_PRIVATE_KEY: ${{ secrets.GITHUB_APP_PRIVATE_KEY }}
61-
GITHUB_APP_CLIENT_ID: ${{ secrets.GITHUB_APP_CLIENT_ID }}
59+
GITHUB_APP_NAME: "GHA OIDC Token Exchange"
60+
GITHUB_APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
61+
GITHUB_APP_CLIENT_ID: "Iv23ligOPEIJDirDT4V5"
6262
ALLOWED_AUDIENCE: "test"
63-
ALLOWED_ISSUER: "https://token.actions.githubusercontent.com"

0 commit comments

Comments
 (0)