Skip to content

Commit b1c8062

Browse files
committed
Improved TestNilAndEmptyBytes
I forgot that bytes.Equals treats nil and []byte{} as equal.
1 parent 85e456e commit b1c8062

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

sqlite3_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1391,7 +1391,9 @@ func TestNilAndEmptyBytes(t *testing.T) {
13911391
if err = rows.Err(); err != nil {
13921392
t.Fatal(tst.name, err)
13931393
}
1394-
if !bytes.Equal(scanBytes, tst.expectedBytes) {
1394+
if tst.expectedBytes == nil && scanBytes != nil {
1395+
t.Errorf("%s: %#v != %#v", tst.name, scanBytes, tst.expectedBytes)
1396+
} else if !bytes.Equal(scanBytes, tst.expectedBytes) {
13951397
t.Errorf("%s: %#v != %#v", tst.name, scanBytes, tst.expectedBytes)
13961398
}
13971399
}

0 commit comments

Comments
 (0)