Skip to content

SetFileControlInt performs unsafe conversion from Go int to C intΒ #1299

@rittneje

Description

@rittneje

Go int and C int are not guaranteed to be the same size. But right now SetFileControlInt blindly casts an int to a C.int, which can overflow or underflow. This is partially responsible for the issue described in #1298. (Even if they were the same size, it still would have been wrong for that op code because SQLite always wants a 64-bit argument even on a 32-bit architecture.)

Fix SetFileControlInt to do explicit bounds checking before casting, and return an error if the number would overflow or underflow.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions