prefer let for variable that does not need to be mutated.

mattpolzin · mattpolzin · commit cae14e9a0326 · 2024-03-01T12:08:46.000-06:00
diff --git a/Sources/JSONAPI/Resource/Relationship.swift b/Sources/JSONAPI/Resource/Relationship.swift
@@ -402,9 +402,11 @@ extension ToManyRelationship: Codable {
         }
 
         let hasData = container.contains(.data)
-        var canHaveNoDataInRelationships: Bool = false
+        let canHaveNoDataInRelationships: Bool
         if let relatableType = Relatable.self as? ResourceObjectWithOptionalDataInRelationships.Type {
             canHaveNoDataInRelationships = relatableType.canHaveNoDataInRelationships
+        } else {
+          canHaveNoDataInRelationships = false
         }
         guard hasData || !canHaveNoDataInRelationships else {
             idsWithMeta = []

Original file line number	Diff line number	Diff line change
`@@ -402,9 +402,11 @@ extension ToManyRelationship: Codable {`
`402`	`402`	`}`
`403`	`403`
`404`	`404`	`let hasData = container.contains(.data)`
`405`		`- var canHaveNoDataInRelationships: Bool = false`
	`405`	`+ let canHaveNoDataInRelationships: Bool`
`406`	`406`	`if let relatableType = Relatable.self as? ResourceObjectWithOptionalDataInRelationships.Type {`
`407`	`407`	`canHaveNoDataInRelationships = relatableType.canHaveNoDataInRelationships`
	`408`	`+ } else {`
	`409`	`+ canHaveNoDataInRelationships = false`
`408`	`410`	`}`
`409`	`411`	`guard hasData \|\| !canHaveNoDataInRelationships else {`
`410`	`412`	`idsWithMeta = []`