Fixing unicode errors with names

Author: mattrobenolt

sourcemap/decoder.py

@@ -11,6 +11,7 @@
 :license: BSD, see LICENSE for more details.
 """
 import os
+import sys
 from functools import partial
 from .exceptions import SourceMapDecodeError
 from .objects import Token, SourceMapIndex
@@ -21,6 +22,10 @@
 
 __all__ = ('SourceMapDecoder',)
 
+# True if we are running on Python 3.
+PY3 = sys.version_info[0] == 3
+text_type = str if PY3 else unicode
+
 
 class SourceMapDecoder(object):
     def parse_vlq(self, segment):
@@ -105,7 +110,7 @@ def decode(self, source):
         smap = json.loads(source)
         sources = smap['sources']
         sourceRoot = smap.get('sourceRoot')
-        names = list(map(str, smap['names']))
+        names = list(map(text_type, smap['names']))
         mappings = smap['mappings']
         lines = mappings.split(';')
 

tests/fixtures/unicode.js

@@ -0,0 +1,4 @@
+var ñ = 10;
+if (ñ == 5) {
+  alert('lol');
+}

tests/fixtures/unicode.min.js

@@ -0,0 +1,4 @@
+var ñ=10;if(ñ==5){alert("lol")}
+/*
+//@ sourceMappingURL=tests/fixtures/unicode.min.map
+*/

tests/fixtures/unicode.min.map

@@ -59,3 +59,9 @@ def test_coolstuff(self):
             end = start + len(token.name)
             substring = source_line[start:end]
             assert token.name == substring
+
+    def test_unicode_names(self):
+        _, _, min_map = self.get_fixtures('unicode')
+
+        # This shouldn't blow up
+        sourcemap.loads(min_map)