Skip to content

Commit b33de41

Browse files
Apply suggestions from code review
1 parent 6141f85 commit b33de41

File tree

2 files changed

+4
-18
lines changed

2 files changed

+4
-18
lines changed

modules/API/BUILD.bazel

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_unit_test")
22
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library")
3-
load("@build_bazel_rules_apple//apple/testing/default_runner:ios_test_runner.bzl", "ios_test_runner")
4-
load("//tools:shared.bzl", "versions")
3+
load("//tools:shared.bzl", "default_test_runner", "versions")
54

65
# Code
76

@@ -31,16 +30,10 @@ swift_library(
3130
],
3231
)
3332

34-
ios_test_runner(
35-
name = "IPHONE_16",
36-
device_type = "iPhone 16",
37-
os_version = versions.minimum_ios_version,
38-
)
39-
4033
ios_unit_test(
4134
name = "APITests",
4235
minimum_os_version = versions.minimum_ios_version,
4336
visibility = ["//modules:default_test_visibility"],
4437
deps = [":APITestsLib"],
45-
runner = "IPHONE_16",
38+
runner = default_test_runner,
4639
)

modules/Models/BUILD.bazel

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_unit_test")
22
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library")
3-
load("@build_bazel_rules_apple//apple/testing/default_runner:ios_test_runner.bzl", "ios_test_runner")
4-
load("//tools:shared.bzl", "versions")
3+
load("//tools:shared.bzl", "default_test_runner", "versions")
54

65
# Code
76

@@ -28,16 +27,10 @@ swift_library(
2827
],
2928
)
3029

31-
ios_test_runner(
32-
name = "IPHONE_16",
33-
device_type = "iPhone 16",
34-
os_version = versions.minimum_ios_version,
35-
)
36-
3730
ios_unit_test(
3831
name = "ModelsTests",
3932
minimum_os_version = versions.minimum_ios_version,
4033
visibility = ["//modules:default_test_visibility"],
4134
deps = [":ModelsTestsLib"],
42-
runner = "IPHONE_16",
35+
runner = default_test_runner,
4336
)

0 commit comments

Comments
 (0)