Nitpick style.

Author: mattstein

datespan.php

@@ -9,14 +9,14 @@
 
 date_default_timezone_set(timezone_name_from_abbr($timezoneAbbreviation));
 
-$dates = explode(" to ", trim(@$argv[1])); // split arguments by " to "
+$dates = explode(" to ", trim(@$argv[1])); // Split arguments by " to "
 
 array_map(static function($dateString) {
     return str_replace('-', '/', $dateString);
 }, $dates);
 
-/*
- * use the current date and time in lieu of a second argument
+/**
+ * Use the current date and time in lieu of a second argument
  */
 
 try {
@@ -33,23 +33,23 @@
 $minutes        = (int) $diff->format('%i');
 $hours          = (int) $diff->format('%h');
 $days           = (int) $diff->format('%d');
-$total_days     = (int) $diff->format('%a');
-$total_hours    = $total_days * 24;
-$total_minutes  = $total_hours * 60;
+$totalDays     = (int) $diff->format('%a');
+$totalHours    = $totalDays * 24;
+$totalMinutes  = $totalHours * 60;
 $weeks          = (int) $diff->format('%a') / 7;
-$business_weeks = (int) $diff->format('%a') / 5;
+$businessWeeks = (int) $diff->format('%a') / 5;
 $months         = (int) $diff->format('%m');
 $years          = (int) $diff->format('%y');
 $sign           = $diff->format('%R');
 
-if ($total_days > 1) {
+if ($totalDays > 1) {
 	$days++;
 }
 
 
 /*
- * a single, complete string; may include years, months, days, hours, minutes, 
- * and "ago" if there's only one parameter and it's in the past
+ * A single, complete string; may include years, months, days, hours, minutes,
+ * and “ago” if there’s only one parameter and it’s in the past
  */
 
 $complete = [];
@@ -61,38 +61,28 @@
 if ($minutes) { $complete[] = pluralize('minute', $minutes); }
 
 if (count($complete) > 1) {
-	$complete_string = implode(', ', array_slice($complete, 0, -1));
-	$complete_string .= " and ".$complete[count($complete)-1];
+	$completeString = implode(', ', array_slice($complete, 0, -1));
+	$completeString .= " and ".$complete[count($complete)-1];
 } else {
-	$complete_string = implode(', ', $complete);
+	$completeString = implode(', ', $complete);
 }
 
 if ( ! isset($dates[1]) && $sign === "+") {
-	$complete_string .= " ago";
+	$completeString .= " ago";
 }
 
 $workflow->item()
-    ->title($complete_string)
-    ->arg($complete_string)
+    ->title($completeString)
+    ->arg($completeString)
     ->subtitle('Copy to clipboard');
 
-
-/*
- * include business weeks if we have them
- */
-
-if ($business_weeks > 0) {
+if ($businessWeeks > 0) {
     $workflow->item()
-        ->title(pluralize('business week', $business_weeks))
-        ->arg(pluralize('business week', $business_weeks))
+        ->title(pluralize('business week', $businessWeeks))
+        ->arg(pluralize('business week', $businessWeeks))
         ->subtitle('Copy to clipboard');
 }
 
-
-/*
- * include weeks if we have them
- */
-
 if ($weeks > 0) {
     $workflow->item()
         ->title(pluralize('week', $weeks))
@@ -101,50 +91,38 @@
 }
 
 
-/*
- * if the *total* number of days is different from days factoring into the interval,
- * we should include it because it's probably interesting
+/**
+ * If the *total* number of days is different from days factoring into the interval,
+ * we should include it because it’s probably interesting.
  */
-
-if ($total_days > $days) {
+if ($totalDays > $days) {
     $workflow->item()
-        ->title(pluralize('day', $total_days))
-        ->arg(pluralize('day', $total_days))
+        ->title(pluralize('day', $totalDays))
+        ->arg(pluralize('day', $totalDays))
         ->subtitle('Copy to clipboard');
 }
 
-
-/*
- * include a total count of hours if we've got them
- */
-
-if ($total_hours > 0) {
+if ($totalHours > 0) {
     $workflow->item()
-        ->title(pluralize('hour', $total_hours))
-        ->arg(pluralize('hour', $total_hours))
+        ->title(pluralize('hour', $totalHours))
+        ->arg(pluralize('hour', $totalHours))
         ->subtitle('Copy to clipboard');
 }
 
-
-/*
- * include a total count of minutes if we've got them
- */
-
-if ($total_minutes > 0) {
+if ($totalMinutes > 0) {
     $workflow->item()
-        ->title(pluralize('minute', $total_minutes))
-        ->arg(pluralize('minute', $total_minutes))
+        ->title(pluralize('minute', $totalMinutes))
+        ->arg(pluralize('minute', $totalMinutes))
         ->subtitle('Copy to clipboard');
 }
 
 $workflow->output();
 
 
-/*
- * make pretty numbers, and add "s"'s if needed
+/**
+ * Format numbers and pluralize as needed.
  */
-
 function pluralize($label, $value): string
 {
-	return number_format($value) . " ". $label . ($value !== 1 ? "s" : "");
+	return number_format($value) . " " . $label . ($value !== 1 ? "s" : "");
 }