cleanups of unused stuff.

Author: matu3ba

lib/std/child_process.zig

@@ -100,11 +100,6 @@ pub const ChildProcess = struct {
         Close,
     };
 
-    pub const PipeDirection = enum {
-        parent_to_child,
-        child_to_parent,
-    };
-
     /// First argument in argv is the executable.
     pub fn init(argv: []const []const u8, allocator: mem.Allocator) ChildProcess {
         return .{
@@ -934,9 +929,6 @@ pub const ChildProcess = struct {
         const cmd_line = try windowsCreateCommandLine(self.allocator, self.argv);
         defer self.allocator.free(cmd_line);
 
-        // TODO use explicit list of file handles
-        // https://devblogs.microsoft.com/oldnewthing/20111216-00/?p=8873
-
         var siStartInfo = windows.STARTUPINFOW{
             .cb = @sizeOf(windows.STARTUPINFOW),
             .hStdError = g_hChildStd_ERR_Wr,
@@ -1118,7 +1110,7 @@ pub const ChildProcess = struct {
 
 const PortPipeT = if (builtin.os.tag == .windows) [2]windows.HANDLE else [2]os.fd_t;
 
-/// Portable pipe creation without handle inheritance
+/// Portable pipe creation with disabled inheritance
 pub inline fn portablePipe() !PortPipeT {
     // TODO think how to offer user an interface to lpSecurityDescriptor
     var pipe_new: PortPipeT = undefined;
@@ -1383,7 +1375,7 @@ fn windowsCreateProcess(app_name: [*:0]u16, cmd_line: [*:0]u16, envp_ptr: ?[*]u1
         null,
         null,
         windows.TRUE,
-        windows.CREATE_UNICODE_ENVIRONMENT,
+        windows.PROCESS_CREATION_FLAGS.CREATE_UNICODE_ENVIRONMENT,
         @ptrCast(?*anyopaque, envp_ptr),
         cwd_ptr,
         lpStartupInfo,
@@ -1507,10 +1499,8 @@ fn windowsMakePipeIn(rd: *?windows.HANDLE, wr: *?windows.HANDLE, sattr: *const w
 
 var pipe_name_counter = std.atomic.Atomic(u32).init(1);
 
-/// Create asynchronous pipe.
-/// To enable inheritance between parent and child process, set bInheritHandle = windows.TRUE
-/// in the security attributes.
-/// Direction defines which handle is updated (to enable inheritance by ChildProcess)
+/// To enable/disable inheritance parent and child process, use
+/// os.enableInheritance() and os.disableInheritance() on the handle.
 pub fn windowsMakeAsyncPipe(
     rd: *windows.HANDLE,
     wr: *windows.HANDLE,