🎨 [Frontend] RTC: support removing links (ITISFoundation#8190)

Author: odeimaiz

services/static-webserver/client/source/class/osparc/Preferences.js

@@ -119,7 +119,7 @@ qx.Class.define("osparc.Preferences", {
     jobConcurrencyLimit: {
       check: "Number",
       nullable: false,
-      init: 4,
+      init: 1,
       event: "changeJobConcurrencyLimit",
       apply: "__patchPreference"
     },
@@ -210,7 +210,11 @@ qx.Class.define("osparc.Preferences", {
         .catch(err => osparc.FlashMessenger.logError(err));
     },
 
-    __patchPreference: function(value, _, propName) {
+    __patchPreference: function(value, old, propName) {
+      // only patch if the value changed
+      if (value === old) {
+        return;
+      }
       this.self().patchPreference(propName, value);
     }
   }

services/static-webserver/client/source/class/osparc/data/model/Node.js

@@ -1440,14 +1440,18 @@ qx.Class.define("osparc.data.model.Node", {
           case "inputs": {
             const updatedPortKey = path.split("/")[4];
             const currentInputs = this.__getInputData();
+            if (osparc.utils.Ports.isDataALink(currentInputs[updatedPortKey])) {
+              // if the port is a link, we remove it from the props form
+              this.getPropsForm().removePortLink(updatedPortKey);
+            }
             currentInputs[updatedPortKey] = value;
             this.__setInputData(currentInputs);
             break;
           }
           case "inputsUnits": {
             // this is never transmitted by the frontend
             const updatedPortKey = path.split("/")[4];
-            const currentInputUnits = this.__getInputUnits();
+            const currentInputUnits = this.__getInputUnits() || {};
             currentInputUnits[updatedPortKey] = value;
             this.__setInputUnits(currentInputUnits);
             break;

services/static-webserver/client/source/class/osparc/store/Products.js

@@ -38,23 +38,12 @@ qx.Class.define("osparc.store.Products", {
         }
 
         Promise.all([
-          osparc.data.Resources.fetch("productMetadata", "getUiConfig"),
-          osparc.utils.Utils.fetchJSON("/resource/osparc/ui_config.json"),
+          this.__getUIConfig(),
           osparc.utils.Utils.fetchJSON("/resource/schemas/product-ui.json"),
         ])
           .then(values => {
-            let uiConfig = {};
-            const beUiConfig = values[0];
-            const feUiConfig = values[1];
-            const schema = values[2];
-            if (beUiConfig && beUiConfig["ui"] && Object.keys(beUiConfig["ui"]).length) {
-              uiConfig = beUiConfig["ui"];
-            } else {
-              const product = osparc.product.Utils.getProductName();
-              if (feUiConfig && product in feUiConfig) {
-                uiConfig = feUiConfig[product];
-              }
-            }
+            const uiConfig = values[0];
+            const schema = values[1];
             const ajvLoader = new qx.util.DynamicScriptLoader([
               "/resource/ajv/ajv-6-11-0.min.js",
               "/resource/object-path/object-path-0-11-4.min.js"
@@ -85,6 +74,46 @@ qx.Class.define("osparc.store.Products", {
       });
     },
 
+    __getUIConfig: function() {
+      return Promise.all([
+        this.__getUiConfigBackend(),
+        this.__getUiConfigFrontend(),
+      ])
+        .then(values => {
+          const beUiConfig = values[0];
+          if (beUiConfig) {
+            return beUiConfig;
+          }
+          const feUiConfig = values[1];
+          return feUiConfig || {};
+        });
+    },
+
+    __getUiConfigBackend: function() {
+      if (osparc.auth.Data.getInstance().isGuest()) {
+        // Guest users do not have access to product metadata
+        return Promise.resolve(null);
+      }
+      return osparc.data.Resources.fetch("productMetadata", "getUiConfig")
+        .then(response => {
+          if (response && response["ui"] && Object.keys(response["ui"]).length) {
+            return response["ui"];
+          }
+          return null;
+        });
+    },
+
+    __getUiConfigFrontend: function() {
+      return osparc.utils.Utils.fetchJSON("/resource/osparc/ui_config.json")
+        .then(uiConfig => {
+          const product = osparc.product.Utils.getProductName();
+          if (uiConfig && product in uiConfig) {
+            return uiConfig[product];
+          }
+          return null;
+        });
+    },
+
     getPlusButtonUiConfig: function() {
       return this.__uiConfig["plusButton"];
     },

services/static-webserver/client/source/class/osparc/viewer/NodeViewer.js

@@ -41,7 +41,11 @@ qx.Class.define("osparc.viewer.NodeViewer", {
           }, this);
         }
       })
-      .catch(err => console.error(err));
+      .catch(err => {
+        console.error(err);
+        osparc.FlashMessenger.logError(err);
+        qx.core.Init.getApplication().logout();
+      });
   },
 
   properties: {