Rename interval & builtIn eval imports

[mauriciopoppe]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @mauriciopoppe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily enhances the codebase's readability and maintainability by standardizing the naming conventions for evaluation function imports within the builtIn and interval samplers. This change makes the specific type of evaluation being performed more immediately apparent. Beyond the renaming, the PR also includes an update to the Interval class's type definition and introduces new parameters and variables in key sampler functions, which appear to lay groundwork for future functional improvements or refinements in how data is processed and rendered.

Highlights

• Import Renaming for Clarity: The builtIn evaluation function import in src/samplers/builtIn.ts has been renamed from evaluate to builtInEvaluate, and similarly, the interval evaluation function import in src/samplers/interval.ts has been renamed from evaluate to intervalEvaluate. This improves clarity by making the origin of the evaluation functions explicit.
• Cross-Sampler Evaluation Imports: The intervalEvaluate function is now imported into src/samplers/builtIn.ts, and the builtInEvaluate function is imported into src/samplers/interval.ts, enabling potential cross-usage between the samplers.
• Type Definition Update: A constructor type definition constructor(lo: number | Interval, hi?: number) has been added to the Interval class in src/external.d.ts, enhancing type safety and autocompletion for Interval object creation.
• Sampler Function Enhancements: The interval1d function in src/samplers/interval.ts now accepts a yAxis parameter and includes new variables oldYBuiltIn and yBuiltIn. Additionally, a new oldY variable was introduced in the linear function within src/samplers/builtIn.ts, likely in preparation for further logic related to asymptote detection or interval calculations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the code to use more specific import names for evaluation functions, which improves clarity. My review focuses on some leftover code that was likely introduced during this refactoring. I've pointed out several instances of unused variables, parameters, and imports in src/samplers/builtIn.ts and src/samplers/interval.ts. Removing this dead code will improve the maintainability of the codebase.