Copilot review follow-up: Remove redundant code in GPS aggregate handling

Author: Tory9

src/Vehicle/FactGroups/VehicleGPS2FactGroup.h

@@ -19,7 +19,7 @@ class VehicleGPS2FactGroup : public VehicleGPSFactGroup
     explicit VehicleGPS2FactGroup(QObject *parent = nullptr)
         : VehicleGPSFactGroup(parent)
     {
-        _setGnssIntegrityContext(1, QStringLiteral("GPS2"));
+        _setGnssIntegrityContext(1);
     }
 
     // Overrides from VehicleGPSFactGroup

src/Vehicle/FactGroups/VehicleGPSAggregateFactGroup.cc

@@ -56,22 +56,21 @@ void VehicleGPSAggregateFactGroup::bindToGps(VehicleGPSFactGroup* gps1, VehicleG
     _gps1 = gps1;
     _gps2 = gps2;
 
-    auto connectFact = [this](Fact* fact, const QString& name) {
+    auto connectFact = [this](Fact* fact) {
         if (fact) {
-            Q_UNUSED(name);
             _connections << connect(fact, &Fact::valueChanged, this, &VehicleGPSAggregateFactGroup::_onIntegrityUpdated);
         }
     };
 
     if (_gps1) {
-        connectFact(_gps1->spoofingState(), "GPS1 spoofingState");
-        connectFact(_gps1->jammingState(), "GPS1 jammingState");
-        connectFact(_gps1->authenticationState(), "GPS1 authenticationState");
+        connectFact(_gps1->spoofingState());
+        connectFact(_gps1->jammingState());
+        connectFact(_gps1->authenticationState());
     }
     if (_gps2) {
-        connectFact(_gps2->spoofingState(), "GPS2 spoofingState");
-        connectFact(_gps2->jammingState(), "GPS2 jammingState");
-        connectFact(_gps2->authenticationState(), "GPS2 authenticationState");
+        connectFact(_gps2->spoofingState());
+        connectFact(_gps2->jammingState());
+        connectFact(_gps2->authenticationState());
     }
     _updateAggregates();
 }
@@ -94,7 +93,6 @@ void VehicleGPSAggregateFactGroup::_onStaleTimeout()
     _jammingStateFact.setRawValue(255);
     _authenticationStateFact.setRawValue(255);
     _isStaleFact.setRawValue(true);
-    _updateAggregates();
 }
 
 void VehicleGPSAggregateFactGroup::_clearConnections()

src/Vehicle/FactGroups/VehicleGPSFactGroup.cc

@@ -51,13 +51,12 @@ VehicleGPSFactGroup::VehicleGPSFactGroup(QObject *parent)
     _gnssSignalQualityFact.setRawValue(255);
     _postProcessingQualityFact.setRawValue(255);
 
-    _setGnssIntegrityContext(0, QStringLiteral("GPS1"));
+    _setGnssIntegrityContext(0);
 }
 
-void VehicleGPSFactGroup::_setGnssIntegrityContext(uint8_t id, const QString& logPrefix)
+void VehicleGPSFactGroup::_setGnssIntegrityContext(uint8_t id)
 {
     _gnssIntegrityId = id;
-    _gnssLogPrefix = logPrefix;
 }
 
 void VehicleGPSFactGroup::handleMessage(Vehicle *vehicle, const mavlink_message_t &message)

src/Vehicle/FactGroups/VehicleGPSFactGroup.h

@@ -55,8 +55,7 @@ class VehicleGPSFactGroup : public FactGroup
 
     // Overrides from FactGroup
     void handleMessage(Vehicle *vehicle, const mavlink_message_t &message) override;
-    
-    void _setGnssIntegrityContext(uint8_t id, const QString& logPrefix);
+    void _setGnssIntegrityContext(uint8_t id);
 
 protected:
     void _handleGpsRawInt(const mavlink_message_t &message);
@@ -83,5 +82,4 @@ class VehicleGPSFactGroup : public FactGroup
     Fact _postProcessingQualityFact = Fact(0, QStringLiteral("postProcessingQuality"), FactMetaData::valueTypeUint8);
 
     uint8_t _gnssIntegrityId;
-    QString _gnssLogPrefix;
 };