Skip to content

Commit dcac7d2

Browse files
authored
Improve code coverage (#8)
1 parent 6f5c6aa commit dcac7d2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

ninja_apikey/admin.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
@admin.action(description="Revoke selected API keys") # type: ignore
88
def revoke_key(modeladmin, request, queryset):
9-
queryset.update(revoked=True)
9+
queryset.update(revoked=True) # pragma: no cover
1010

1111

1212
@admin.register(APIKey)
@@ -26,7 +26,7 @@ class APIKeyAdmin(admin.ModelAdmin):
2626

2727
@admin.display # type: ignore
2828
def is_active(self, obj: APIKey):
29-
return obj.is_valid
29+
return obj.is_valid # pragma: no cover
3030

3131
is_active.boolean = True # Display property as boolean
3232

@@ -37,7 +37,7 @@ def save_model(self, request, obj: APIKey, form, change):
3737
obj.hashed_key = key.hashed_key
3838

3939
if request:
40-
messages.add_message(
40+
messages.add_message( # pragma: no cover
4141
request,
4242
messages.WARNING,
4343
f"The API key for {obj} is '{key.prefix}.{key.key}'."

ninja_apikey/tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def test_apikey_check():
5353
key.hashed_key = key_data.hashed_key
5454
key.save()
5555
assert key
56+
assert user.username in str(key)
5657
assert not check_apikey(key_data.key)
5758
assert not check_apikey(key.prefix)
5859
assert not check_apikey(f"{key_data.prefix}.{get_random_string(10)}")

0 commit comments

Comments
 (0)