Skip to content

Commit f82c48e

Browse files
authored
Merge pull request #14 from arusakov/remove_object_assign_polyfil
Update deps and tests, remove object-assign polyfill
2 parents 2f3bd24 + b062b35 commit f82c48e

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
language: node_js
22
node_js:
3-
- "5"
3+
- "6"
4+
- "node"
45

56
branches:
67
only:

index.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
'use strict';
22

3+
var path = require('path');
34
var electron = require('electron');
4-
var app = electron.app;
55
var jsonfile = require('jsonfile');
6-
var path = require('path');
76
var mkdirp = require('mkdirp');
8-
var objectAssign = require('object-assign');
97
var deepEqual = require('deep-equal');
108

119
module.exports = function (options) {
10+
var app = electron.app;
1211
var screen = electron.screen;
1312
var state;
1413
var winRef;
1514
var stateChangeTimer;
1615
var eventHandlingDelay = 100;
17-
var config = objectAssign({
16+
var config = Object.assign({
1817
file: 'window-state.json',
1918
path: app.getPath('userData'),
2019
maximize: true,
@@ -97,7 +96,7 @@ module.exports = function (options) {
9796
try {
9897
mkdirp.sync(path.dirname(fullStoreFileName));
9998
jsonfile.writeFileSync(fullStoreFileName, state);
100-
} catch (e) {
99+
} catch (err) {
101100
// Don't care
102101
}
103102
}
@@ -154,7 +153,7 @@ module.exports = function (options) {
154153
validateState();
155154

156155
// Set state fallback values
157-
state = objectAssign({
156+
state = Object.assign({
158157
width: config.defaultWidth || 800,
159158
height: config.defaultHeight || 600
160159
}, state);

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"main": "index.js",
88
"author": "Marcel Wiehle",
99
"engines": {
10-
"node": ">=0.12.0"
10+
"node": ">=4.0.0"
1111
},
1212
"scripts": {
1313
"test": "xo && ava"
@@ -21,14 +21,13 @@
2121
"dependencies": {
2222
"deep-equal": "^1.0.1",
2323
"jsonfile": "^2.2.3",
24-
"mkdirp": "^0.5.1",
25-
"object-assign": "^4.0.1"
24+
"mkdirp": "^0.5.1"
2625
},
2726
"devDependencies": {
28-
"ava": "^0.7.0",
27+
"ava": "^0.17.0",
2928
"mockery": "^1.4.0",
3029
"sinon": "^1.17.2",
31-
"xo": "^0.11.2"
30+
"xo": "^0.17.1"
3231
},
3332
"xo": {
3433
"space": true,

test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ test('maximize and set the window fullscreen if enabled', t => {
126126
const state = require('./')({defaultWidth: 1000, defaultHeight: 2000});
127127
state.manage(win);
128128

129-
t.ok(win.maximize.calledOnce);
130-
t.ok(win.setFullScreen.calledOnce);
129+
t.truthy(win.maximize.calledOnce);
130+
t.truthy(win.setFullScreen.calledOnce);
131131
jsonfile.readFileSync.restore();
132132
});
133133

@@ -158,8 +158,8 @@ test('saves the state to the file system', t => {
158158
const state = require('./')({defaultWidth: 1000, defaultHeight: 2000});
159159
state.saveState(win);
160160

161-
t.ok(mkdirp.sync.calledOnce);
162-
t.ok(jsonfile.writeFileSync.calledWith('/temp/window-state.json', {
161+
t.truthy(mkdirp.sync.calledOnce);
162+
t.truthy(jsonfile.writeFileSync.calledWith('/temp/window-state.json', {
163163
x: 100,
164164
y: 100,
165165
width: 500,

0 commit comments

Comments
 (0)