Add TaskInfo (or metadata) to Context

[victoronascimento]

Hi @maxcountryman ! Once again, thanks for your great work on this!

I think that Context<S> should have metadata about the task like its id, step index and so on. This would make for better logging / metrics content. Something like:

pub struct Context<S> {
    pub state: S,
    pub tx: Transaction<'static, Postgres>,
    pub task_info: TaskInfo
}

pub struct TaskInfo {
    pub id: Uuid,
    pub attempt: u16,
    pub step_index: u16,
    pub task_queue_name: String,
    // ... and so on
}

If you agree, I can work on a PR. Naming might need better ideas here...

[maxcountryman]

Just bear in mind that the ID already exists. So while yes I agree, I would like to consolidate and not duplicate. I'm also not sure that "task" is right, if this is specific to job.

[maxcountryman]

There's already JobState so please don't introduce a new type that duplicates those fields.

Also bear in mind that the execute method does already log all the fields you mentioned.

[victoronascimento]

I haven't noticed the JobState sealed type. My bad.

In any case, to use the fields there we would expose application code dealing with the dynamic Value there. Maybe having a more strongly typed struct could be a good thing here (just bringing it up for discussion).

About the logging, you are absolutely right. Either way, I still think this is relevant as there are more use cases possible (many different metrics and so on could be extracted here).

This is just a nice to have and not high priority to me. If you think this is currently not the best approach I am ok with moving on.

[maxcountryman]

I'd rather not duplicate the same fields over several types. I'm not opposed to extending Context (that was always the idea) but I'd like it to be thoughtful (what are the real use cases, etc).

[victoronascimento]

My use case here is to add metrics (Cadence in my case as we use DataDog). It'd be nice to have a complete dashboard about all the jobs in the system (per step, per attempt). I see the traces but they are sampled (1 of every 100 or more are registered). So, I'd need to retrieve step index, no of attempts and so on to add to metrics.

[maxcountryman]

Let's add that to Context.

[victoronascimento]

Opened #95