directly open expose from notification

Author: maxhoffmann

README.md

@@ -10,7 +10,7 @@ This is a browser extension for Chromium based browsers ([Vivaldi](https://vival
 - makes sure listing are sorted by latest
 - only reloads search pages, not the pages of single listing
 - previews the listing title in notifications
-- clicking on a notification focuses the tab with the new listing
+- clicking on a notification opens a new tab with the new listing
 
 ## Visual improvements
 

background.js

@@ -40,12 +40,14 @@ chrome.tabs.onUpdated.addListener((tabId, changeInfo, tab) => {
           console.log(new Date().toLocaleString());
           if (addedIds.size > 0 && prevIds.size > 0) {
             console.info(`‼️ ${addedIds.size} new listings`, addedIds);
-            const titles = [...addedIds].map((id) => titleById[id]);
-            showNotification(
-              tabId,
-              `${addedIds.size} ${addedIds.size === 1 ? "neue Anzeige" : "neue Anzeigen"}`,
-              titles.join(" · "),
-            );
+            const ids = [...addedIds];
+            for (const id of ids) {
+              showNotification(
+                id,
+                `${addedIds.size} ${addedIds.size === 1 ? "neue Anzeige" : "neue Anzeigen"}`,
+                titleById[id],
+              );
+            }
           } else {
             console.log("no new listings", prevIds);
           }
@@ -65,11 +67,12 @@ chrome.tabs.onUpdated.addListener((tabId, changeInfo, tab) => {
 chrome.notifications.onClicked.addListener(async (notificationId) => {
   const prefix = "immo24:";
   if (notificationId.startsWith(prefix)) {
-    const tabId = parseInt(notificationId.slice(prefix.length), 10);
-    if (!isNaN(tabId)) {
+    const exposeId = parseInt(notificationId.slice(prefix.length), 10);
+    if (!isNaN(exposeId)) {
       try {
-        const tab = await chrome.tabs.get(tabId);
-        await chrome.tabs.update(tabId, { active: true });
+        const tab = await chrome.tabs.create({
+          url: `https://www.immobilienscout24.de/expose/${exposeId}`,
+        });
         await chrome.windows.update(tab.windowId, { focused: true });
       } catch (err) {
         console.error("Failed to focus tab", err);
@@ -93,8 +96,8 @@ function collectListingIds() {
 }
 
 // Show notification from service worker
-async function showNotification(tabId, title, message) {
-  await chrome.notifications.create("immo24:" + tabId, {
+async function showNotification(exposeId, title, message) {
+  await chrome.notifications.create("immo24:" + exposeId, {
     type: "basic",
     iconUrl: "icon-48.png",
     title: title,

manifest.json

@@ -1,36 +1,40 @@
 {
-    "name": "Immo24 Notifier",
-    "version": "1.1.0",
-    "manifest_version": 3,
-    "description": "Immo24 Notifier extension by Maximilian Hoffmann",
-    "homepage_url": "https://github.com/maxhoffmann/immo-extension",
-    "permissions": [
-      "tabs",
-      "notifications",
-      "scripting"
-    ],
-    "host_permissions": [
-      "https://www.immobilienscout24.de/*"
-    ],
-    "icons": {
-      "16": "icon-16.png",
-      "19": "icon-19.png",
-      "38": "icon-38.png",
-      "48": "icon-48.png",
-      "128": "icon-128.png"
-    },
-    "action": {
-      "default_title": "Immo24 Notifier",
-      "default_icon": "icon-128.png",
-      "default_popup": "popup.html"
-    },
-    "background": {
-      "service_worker": "background.js"
-    },
-    "content_scripts": [
-        {
-            "matches": ["https://www.immobilienscout24.de/*"],
-            "css": ["immo.css"]
-        }
-    ]
+  "name": "Immo24 Notifier",
+  "version": "2.0.0",
+  "manifest_version": 3,
+  "description": "Immo24 Notifier extension by Maximilian Hoffmann",
+  "homepage_url": "https://github.com/maxhoffmann/immo-extension",
+  "permissions": [
+    "tabs",
+    "notifications",
+    "scripting"
+  ],
+  "host_permissions": [
+    "https://www.immobilienscout24.de/*"
+  ],
+  "icons": {
+    "16": "icon-16.png",
+    "19": "icon-19.png",
+    "38": "icon-38.png",
+    "48": "icon-48.png",
+    "128": "icon-128.png"
+  },
+  "action": {
+    "default_title": "Immo24 Notifier",
+    "default_icon": "icon-128.png",
+    "default_popup": "popup.html"
+  },
+  "background": {
+    "service_worker": "background.js"
+  },
+  "content_scripts": [
+    {
+      "matches": [
+        "https://www.immobilienscout24.de/*"
+      ],
+      "css": [
+        "immo.css"
+      ]
+    }
+  ]
 }