reduce warnings

Author: maxijabase

SourceServerManager/Converters/BoolToColorConverter.cs

@@ -7,7 +7,7 @@ namespace SourceServerManager.Converters;
 
 public class BoolToColorConverter : IValueConverter
 {
-    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    public object Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         if (value is bool isOnline)
         {
@@ -17,7 +17,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
         return new SolidColorBrush(Colors.Gray);
     }
 
-    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    public object ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         throw new NotImplementedException();
     }

SourceServerManager/Converters/BoolToStatusConverter.cs

@@ -6,7 +6,7 @@ namespace SourceServerManager.Converters;
 
 public class BoolToStatusConverter : IValueConverter
 {
-    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    public object Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         if (value is bool isOnline)
         {
@@ -16,7 +16,7 @@ public object Convert(object value, Type targetType, object parameter, CultureIn
         return "Unknown";
     }
 
-    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    public object ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         throw new NotImplementedException();
     }

SourceServerManager/Converters/EnumToIntConverter.cs

@@ -6,17 +6,17 @@ namespace SourceServerManager.Converters;
 
 public class EnumToIntConverter : IValueConverter
 {
-    public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
+    public object Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         if (value is Enum)
             return (int)value;
         return 0;
     }
 
-    public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)
+    public object ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture)
     {
         if (value is int intValue && targetType.IsEnum)
             return Enum.ToObject(targetType, intValue);
-        return Enum.GetValues(targetType).GetValue(0);
+        return Enum.GetValues(targetType).GetValue(0) ?? 0;
     }
 }

SourceServerManager/Models/ServerConfig.cs

@@ -23,20 +23,20 @@ public class ServerConfig : INotifyPropertyChanged
     private string _currentMap = string.Empty;
     private string _serverHostname = string.Empty;
 
-    public event PropertyChangedEventHandler PropertyChanged;
+    public event PropertyChangedEventHandler? PropertyChanged;
 
     public enum FileTransferProtocol
     {
         FTP,
         SFTP
     }
 
-    protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
+    protected virtual void OnPropertyChanged([CallerMemberName] string? propertyName = null)
     {
         PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));
     }
 
-    protected bool SetField<T>(ref T field, T value, [CallerMemberName] string propertyName = null)
+    protected bool SetField<T>(ref T field, T value, [CallerMemberName] string? propertyName = null)
     {
         if (Equals(field, value)) return false;
         field = value;

SourceServerManager/Services/ServerConfigurationService.cs

@@ -13,7 +13,7 @@ public class ServerConfigurationService
     private readonly string _configFilePath;
     private readonly JsonSerializerOptions _jsonOptions;
 
-    public ServerConfigurationService(string configFilePath = null)
+    public ServerConfigurationService(string? configFilePath = null)
     {
         // Use default path if none specified
         _configFilePath = configFilePath ?? Path.Combine(
@@ -23,7 +23,11 @@ public ServerConfigurationService(string configFilePath = null)
         );
 
         // Create directory if it doesn't exist
-        Directory.CreateDirectory(Path.GetDirectoryName(_configFilePath));
+        var configDir = Path.GetDirectoryName(_configFilePath);
+        if (!string.IsNullOrEmpty(configDir))
+        {
+            Directory.CreateDirectory(configDir);
+        }
 
         // Configure JSON serialization options
         _jsonOptions = new JsonSerializerOptions

SourceServerManager/Services/ServerStatusService.cs

@@ -61,7 +61,7 @@ public async Task UpdateServerInfoAsync(ServerConfig server)
             }
 
             // Try to get server info
-            InfoResponse serverInfo = null;
+            InfoResponse? serverInfo = null;
 
             try
             {

SourceServerManager/SourceServerManager.csproj

@@ -6,6 +6,7 @@
     <BuiltInComInteropSupport>true</BuiltInComInteropSupport>
     <ApplicationManifest>app.manifest</ApplicationManifest>
     <AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>
+    <NoWarn>$(NoWarn);CA1416</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

SourceServerManager/ViewModels/MainWindowViewModel.cs

@@ -18,12 +18,12 @@ public class MainWindowViewModel : ViewModelBase
     private readonly RconService _rconService;
     private readonly FtpService _ftpService;
     private readonly SftpService _sftpService;
-    private FilesService _filesService;
+    private FilesService? _filesService;
     private readonly ServerConfigurationService _configService;
     private readonly ServerStatusService _statusService;
     private readonly CommandHistoryService _commandHistoryService;
     private readonly Timer _statusUpdateTimer;
-    private ServerConfig _serverBeingEdited;
+    private ServerConfig? _serverBeingEdited;
     private readonly Timer _statusClearTimer;
     private readonly object _statusLock = new();
 
@@ -71,8 +71,8 @@ public string RemoteBrowsePath
         set => this.RaiseAndSetIfChanged(ref _remoteBrowsePath, value);
     }
 
-    private ServerConfig _selectedServer;
-    public ServerConfig SelectedServer
+    private ServerConfig? _selectedServer;
+    public ServerConfig? SelectedServer
     {
         get => _selectedServer;
         set => this.RaiseAndSetIfChanged(ref _selectedServer, value);
@@ -199,7 +199,7 @@ private async Task<string> ListDirectoryWithCorrectServiceAsync(ServerConfig ser
         }
     }
 
-    private void ClearStatusCallback(object state)
+    private void ClearStatusCallback(object? state)
     {
         Dispatcher.UIThread.Post(() =>
         {
@@ -323,13 +323,16 @@ private void SaveServerEdit()
         // Exit edit mode
         IsEditingServer = false;
 
-        UpdateStatus($"Server configuration saved: {SelectedServer.DisplayName}");
+        UpdateStatus($"Server configuration saved: {SelectedServer?.DisplayName ?? "Unknown"}");
 
         // Save the configuration
         Task.Run(SaveConfigAsync);
 
         // Try to update server status
-        Task.Run(async () => await _statusService.UpdateServerInfoAsync(SelectedServer));
+        if (SelectedServer != null)
+        {
+            Task.Run(async () => await _statusService.UpdateServerInfoAsync(SelectedServer));
+        }
     }
 
     private void CancelEdit()

SourceServerManager/Views/MainWindow.axaml.cs

@@ -10,8 +10,8 @@ namespace SourceServerManager.Views;
 
 public partial class MainWindow : Window
 {
-    private TextBox _rconConsoleTextBox;
-    private TextBox _ftpConsoleTextBox;
+    private TextBox? _rconConsoleTextBox;
+    private TextBox? _ftpConsoleTextBox;
     private string _lastRconConsoleText = string.Empty;
     private string _lastFtpConsoleText = string.Empty;
 
@@ -33,19 +33,21 @@ private void MainWindow_Opened(object? sender, EventArgs e)
         }
     }
 
-    private void ViewModel_PropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
+    private void ViewModel_PropertyChanged(object? sender, System.ComponentModel.PropertyChangedEventArgs e)
     {
         if (e.PropertyName == nameof(MainWindowViewModel.RconConsoleOutput))
         {
-            ScrollToEnd(_rconConsoleTextBox, ((MainWindowViewModel)DataContext).RconConsoleOutput);
+            if (DataContext is MainWindowViewModel vm)
+                ScrollToEnd(_rconConsoleTextBox, vm.RconConsoleOutput);
         }
         else if (e.PropertyName == nameof(MainWindowViewModel.FtpConsoleOutput))
         {
-            ScrollToEnd(_ftpConsoleTextBox, ((MainWindowViewModel)DataContext).FtpConsoleOutput);
+            if (DataContext is MainWindowViewModel vm)
+                ScrollToEnd(_ftpConsoleTextBox, vm.FtpConsoleOutput);
         }
     }
 
-    private void ScrollToEnd(TextBox textBox, string text)
+    private void ScrollToEnd(TextBox? textBox, string text)
     {
         Dispatcher.UIThread.Post(() =>
         {