Update logic to handle errors

Author: Maxim Lobanov

.github/workflows/test.yml

@@ -38,6 +38,27 @@ jobs:
     - name: Validate version
       run: pod --version | grep "1.5.3"
 
+  version-already-installed:
+    name: valid version - already installed
+    runs-on: macos-latest
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v2
+    
+    - name: Remove pre-installed version
+      run: gem uninstall cocoapods --all --executables
+
+    - name: Install needed version
+      run: gem install cocoapods -v 1.8.1
+
+    - name: setup-cocoapods
+      uses: ./
+      with:
+        version: 1.8.1
+
+    - name: Validate version
+      run: pod --version | grep "1.8.1"
+
   version-latest:
     name: latest version
     runs-on: macos-latest

dist/index.js

@@ -1511,7 +1511,7 @@ class CocoapodsInstaller {
             core.info(`Cocoapods ${versionSpec} has already installed. Not needed to re-install.`);
             return;
         }
-        const uninstallExitCode = await exec.exec("gem", ["uninstall", "cocoapods", "--all", "--executables"]);
+        const uninstallExitCode = await exec.exec("gem", ["uninstall", "cocoapods", "--all", "--executables"]).catch(error => error);
         if (uninstallExitCode !== 0) {
             core.info("Error during deleting existing version of cocoapods");
         }
@@ -1539,7 +1539,7 @@ class CocoapodsInstaller {
                 }
             }
         };
-        const exitCode = await exec.exec("pod", ["--version"], options);
+        const exitCode = await exec.exec("pod", ["--version"], options).catch(error => error);
         if (exitCode === 0 && stdOutput) {
             return stdOutput.trim();
         }

src/installer.ts

@@ -1,7 +1,7 @@
 import * as fs from "fs";
-import * as path from 'path';
+import * as path from "path";
 import { EOL } from "os";
-import * as exec from '@actions/exec';
+import * as exec from "@actions/exec";
 import * as core from "@actions/core";
 import { ExecOptions } from "@actions/exec/lib/interfaces";
 
@@ -13,7 +13,7 @@ export class CocoapodsInstaller {
             return;
         }
 
-        const uninstallExitCode = await exec.exec("gem", ["uninstall", "cocoapods", "--all", "--executables"]);
+        const uninstallExitCode = await exec.exec("gem", ["uninstall", "cocoapods", "--all", "--executables"]).catch(error => error);
         if (uninstallExitCode !== 0) {
             core.info("Error during deleting existing version of cocoapods");
         }
@@ -30,7 +30,7 @@ export class CocoapodsInstaller {
         const absolutePath = path.resolve(podfilePath);
 
         if (!fs.existsSync(absolutePath)) {
-            throw new Error(`podfile is not found on path '${absolutePath}'`)
+            throw new Error(`podfile is not found on path '${absolutePath}'`);
         }
 
         const fileContent = fs.readFileSync(absolutePath);
@@ -42,13 +42,13 @@ export class CocoapodsInstaller {
         let stdOutput = "";
         const options: ExecOptions = {
             listeners: {
-                stdout: (data: Buffer) => {
+                stdout: (data: Buffer): void => {
                     stdOutput += data.toString();
                 }
             }
         };
 
-        const exitCode = await exec.exec("pod", ["--version"], options);
+        const exitCode = await exec.exec("pod", ["--version"], options).catch(error => error);
         if (exitCode === 0 && stdOutput) {
             return stdOutput.trim();
         }

src/setup-cocoapods.ts

@@ -11,7 +11,7 @@ const run = async (): Promise<void> => {
         const podfilePathInput = core.getInput("podfile-path", { required: false });
 
         if (!!versionInput === !!podfilePathInput) {
-            throw new Error("Invalid input parameters. Only 'version' or 'podfile-path' should be defined")
+            throw new Error("Invalid input parameters. Only 'version' or 'podfile-path' should be defined");
         }
 
         const versionSpec = versionInput || CocoapodsInstaller.getVersionFromPodfile(podfilePathInput);