Fixed clippy and cargo fmt checks

Author: maxmarsc

src/dsp/data.rs

@@ -147,7 +147,7 @@ impl<T: DspData<P> + Send + 'static, P: Send + 'static> AsyncDspData<T, P> {
             data: None,
             rendered_rx,
             process_handle: Some(join_handle),
-            phantom: PhantomData::default(),
+            phantom: PhantomData,
         }
     }
 }

src/dsp/mod.rs

@@ -6,7 +6,5 @@ mod waveform;
 
 pub use data::{AsyncDspData, AsyncDspDataState, DspData, DspErr};
 pub use spectrogram::{Spectrogram, SpectrogramParameters};
-pub use time_window::{
-    SidePaddingType, WindowType, PADDING_HELP_TEXT,
-};
+pub use time_window::{SidePaddingType, WindowType, PADDING_HELP_TEXT};
 pub use waveform::{Waveform, WaveformParameters, WaveformPoint};

src/dsp/time_window.rs

@@ -324,7 +324,7 @@ impl TimeWindowBatcher {
         // Compute the first sample to seek
         let new_seek_idx = self.crt_band_idx as u64 * self.tband_size as u64;
         self.sndfile
-            .seek(SeekFrom::Start(new_seek_idx as u64))
+            .seek(SeekFrom::Start(new_seek_idx))
             .unwrap_or_else(|_| panic!("Failed to seek frame {}", new_seek_idx));
 
         // The offset left and right of the window lobe

src/render/headers.rs

@@ -107,7 +107,6 @@ impl<'a> ChannelsTabs {
 
     fn states(&'a self) -> Vec<(bool, &'a str)> {
         (0..self.count())
-            .into_iter()
             .map(|idx| {
                 let title = self.titles[idx].as_str();
                 match self.activated.get(&idx) {
@@ -164,10 +163,7 @@ impl<'a> ChannelsTabs {
                 .into_iter()
                 .map(|v| v.to_string())
                 .collect(), // 7.1
-            _ => (0..count)
-                .into_iter()
-                .map(|idx| format!["Channel {:?}", idx])
-                .collect(),
+            _ => (0..count).map(|idx| format!["Channel {:?}", idx]).collect(),
         }
     }
 }

src/render/metadata.rs

@@ -209,7 +209,7 @@ impl Renderer for MetadataRenderer {
         let value_style = Style::default();
 
         // properties
-        let properties = vec![
+        let properties = [
             ("Format", &self.metadata.format),
             ("Format subtype", &self.metadata.subtype),
             ("Endianess", &self.metadata.endianess),

src/render/renderer.rs

@@ -61,9 +61,9 @@ pub fn draw_text_info<B: Backend>(
     text: &str,
 ) {
     let num_lines_to_center: usize = if area.height % 2 == 0 {
-        usize::try_from(area.height).unwrap() / 2 - 1
+        usize::from(area.height) / 2 - 1
     } else {
-        usize::try_from(area.height).unwrap() / 2
+        usize::from(area.height) / 2
     };
 
     let mut span_vec = vec![Spans::from(""); num_lines_to_center];

src/render/waveform.rs

@@ -107,7 +107,7 @@ impl WaveformRenderer {
 
         WaveformRenderer {
             channels,
-            async_renderer: AsyncDspData::new(path, WaveformParameters::default(), normalize),
+            async_renderer: AsyncDspData::new(path, WaveformParameters, normalize),
             max_width_res: max_res,
         }
     }

src/render/widgets/image.rs

@@ -35,7 +35,6 @@ impl<'a> Widget for Image<'a> {
 
         self.img_buffer
             .chunks(6)
-            .into_iter()
             .map(|pixels| {
                 [
                     Color::Rgb(pixels[0], pixels[1], pixels[2]),
@@ -47,13 +46,10 @@ impl<'a> Widget for Image<'a> {
                 let x_char = idx as u16 / img_area.height;
                 let y_char = img_area.height - (idx as u16 % img_area.height) - 1;
 
-                buf.get_mut(
-                    x_char as u16 + img_area.left(),
-                    y_char as u16 + img_area.top(),
-                )
-                .set_char('▄')
-                .set_bg(colors[0])
-                .set_fg(colors[1]);
+                buf.get_mut(x_char + img_area.left(), y_char + img_area.top())
+                    .set_char('▄')
+                    .set_bg(colors[0])
+                    .set_fg(colors[1]);
             });
     }
 }