Skip to content

Commit 23d6c80

Browse files
committed
[UPDATE] Remove trimming in NetworkDeserializer and update tests
1 parent 7b823b0 commit 23d6c80

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/main/java/com/maxmind/geoip2/NetworkDeserializer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public Network deserialize(JsonParser jsonparser, DeserializationContext context
3737
if (cidr == null || cidr.isBlank()) {
3838
return null;
3939
}
40-
return parseCidr(cidr.trim());
40+
return parseCidr(cidr);
4141
}
4242

4343
private static Network parseCidr(String cidr) throws IOException {
@@ -46,8 +46,8 @@ private static Network parseCidr(String cidr) throws IOException {
4646
throw new IllegalArgumentException("Invalid CIDR format: " + cidr);
4747
}
4848

49-
final String addrPart = parts[0].trim();
50-
final String prefixPart = parts[1].trim();
49+
final String addrPart = parts[0];
50+
final String prefixPart = parts[1];
5151

5252
final InetAddress address;
5353
try {

src/test/java/com/maxmind/geoip2/NetworkDeserializerTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,13 @@ void parsesValidIPv6Cidr() throws Exception {
4040
}
4141

4242
@Test
43-
void trimsWhitespace() throws Exception {
44-
Network actual = parse("\" 10.0.0.0/8 \"");
45-
assertNetwork(actual, "10.0.0.0", 8);
43+
void rejectsWhitespaceInCidr() {
44+
assertThrows(IOException.class, () -> parse("\" 10.0.0.0/8 \""));
4645
}
4746

4847

48+
49+
4950
@Test
5051
void returnsNullOnJsonNull() throws Exception {
5152
Network actual = parse("null");

0 commit comments

Comments
 (0)