Skip to content

Commit 410b521

Browse files
committed
Revert serializable classes
Although we may want to do this in the future, we first want to figure out how this relates to our versioning policy and whether we want to do custom serialization.
1 parent 13e9bbb commit 410b521

File tree

6 files changed

+11
-21
lines changed

6 files changed

+11
-21
lines changed

src/main/java/com/maxmind/geoip2/model/AbstractCountryResponse.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.maxmind.geoip2.model;
22

3+
import java.io.IOException;
4+
35
import com.fasterxml.jackson.annotation.JsonInclude.Include;
46
import com.fasterxml.jackson.annotation.JsonProperty;
57
import com.fasterxml.jackson.databind.ObjectMapper;
@@ -9,10 +11,7 @@
911
import com.maxmind.geoip2.record.RepresentedCountry;
1012
import com.maxmind.geoip2.record.Traits;
1113

12-
import java.io.IOException;
13-
import java.io.Serializable;
14-
15-
abstract class AbstractCountryResponse implements Serializable {
14+
abstract class AbstractCountryResponse {
1615
@JsonProperty
1716
private Continent continent = new Continent();
1817

src/main/java/com/maxmind/geoip2/record/AbstractNamedRecord.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
package com.maxmind.geoip2.record;
22

3-
import com.fasterxml.jackson.annotation.JacksonInject;
4-
import com.fasterxml.jackson.annotation.JsonProperty;
5-
6-
import java.io.Serializable;
73
import java.util.ArrayList;
84
import java.util.HashMap;
95
import java.util.List;
106
import java.util.Map;
117

8+
import com.fasterxml.jackson.annotation.JacksonInject;
9+
import com.fasterxml.jackson.annotation.JsonProperty;
10+
1211
/**
1312
* Abstract class for records with name maps.
1413
*/
15-
public abstract class AbstractNamedRecord implements Serializable {
14+
public abstract class AbstractNamedRecord {
1615
@JsonProperty
1716
private HashMap<String, String> names = new HashMap<String, String>();
1817
@JsonProperty("geoname_id")

src/main/java/com/maxmind/geoip2/record/Location.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,12 @@
22

33
import com.fasterxml.jackson.annotation.JsonProperty;
44

5-
import java.io.Serializable;
6-
75
/**
86
* Contains data for the location record associated with an IP address.
97
*
108
* This record is returned by all the end points except the Country end point.
119
*/
12-
final public class Location implements Serializable {
10+
final public class Location {
1311
@JsonProperty("accuracy_radius")
1412
private Integer accuracyRadius;
1513

src/main/java/com/maxmind/geoip2/record/MaxMind.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,12 @@
22

33
import com.fasterxml.jackson.annotation.JsonProperty;
44

5-
import java.io.Serializable;
6-
75
/**
86
* Contains data related to your MaxMind account.
97
*
108
* This record is returned by all the end points.
119
*/
12-
final public class MaxMind implements Serializable {
10+
final public class MaxMind {
1311
@JsonProperty("queries_remaining")
1412
private Integer queriesRemaining;
1513

src/main/java/com/maxmind/geoip2/record/Postal.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,12 @@
55

66
import com.fasterxml.jackson.annotation.JsonProperty;
77

8-
import java.io.Serializable;
9-
108
/**
119
* Contains data for the postal record associated with an IP address.
1210
*
1311
* This record is returned by all the end points except the Country end point.
1412
*/
15-
final public class Postal implements Serializable {
13+
final public class Postal {
1614
@JsonProperty
1715
private String code;
1816

src/main/java/com/maxmind/geoip2/record/Traits.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,12 @@
22

33
import com.fasterxml.jackson.annotation.JsonProperty;
44

5-
import java.io.Serializable;
6-
75
/**
86
* Contains data for the traits record associated with an IP address.
97
*
108
* This record is returned by all the end points.
119
*/
12-
final public class Traits implements Serializable {
10+
final public class Traits {
1311
@JsonProperty("autonomous_system_number")
1412
private Integer autonomousSystemNumber;
1513

0 commit comments

Comments
 (0)