Skip to content

Commit 3ed5fca

Browse files
authored
Merge pull request #234 from maxmind/greg/eng-1001-mark-metro-code-data-as-deprecated-in-our-libraries
Deprecate metro code
2 parents aa4cf39 + ce3406e commit 3ed5fca

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
CHANGELOG
22
=========
33

4+
3.2.0
5+
------------------
6+
7+
* `metroCode` on `GeoIp2\Record\Location` has been deprecated. The code
8+
values are no longer being maintained.
9+
410
3.1.0 (2024-11-15)
511
------------------
612

@@ -15,7 +21,7 @@ CHANGELOG
1521
* IMPORTANT: PHP 8.1 or greater is now required.
1622
* BREAKING: Read-only properties are now used for the model and record
1723
classes rather than magic methods. This significantly improves performance.
18-
* BREAKING: The `raw` property on model classess and the `record` property on
24+
* BREAKING: The `raw` property on model classes and the `record` property on
1925
record classes have been removed.
2026
* BREAKING: On `GeoIp2\Record\Traits`, the deprecated `isAnonymousProxy` and
2127
`isSatelliteProvider` properties have been removed.

src/Record/Location.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ class Location implements \JsonSerializable
4343
public readonly ?float $longitude;
4444

4545
/**
46-
* @var int|null The metro code of the location if the location
47-
* is in the US. MaxMind returns the same metro codes as the
48-
* Google AdWords API. See
49-
* https://developers.google.com/adwords/api/docs/appendix/cities-DMAregions.
46+
* @var int|null the metro code is a no-longer-maintained code for targeting
47+
* advertisements in Google
48+
*
49+
* @deprecated
5050
*/
5151
public readonly ?int $metroCode;
5252

0 commit comments

Comments
 (0)