Skip to content

Commit 73a5f68

Browse files
committed
pylint import fix and 3.2 fix.
1 parent f7da388 commit 73a5f68

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ install:
1111
- pip install -r requirements.txt
1212
- pip install git+https://github.com/maxmind/HTTPretty.git
1313
- pip install pylint coveralls
14-
- if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then pip install unittest2 ipaddr; fi
15-
- if [[ $TRAVIS_PYTHON_VERSION == '2.7' ]]; then pip install ipaddr; fi
14+
- if [[ $TRAVIS_PYTHON_VERSION == '2.6' ]]; then pip install unittest2; fi
15+
- if [[ $TRAVIS_PYTHON_VERSION != '3.3' ]]; then pip install ipaddr; fi
1616

1717
script:
1818
- coverage run --source=geoip2 setup.py test

geoip2/webservices.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,12 @@
102102

103103
import sys
104104

105-
if sys.version_info[0] == 2:
106-
import ipaddr as ipaddress
105+
if sys.version_info[0] == 2 or (sys.version_info[0] == 3
106+
and sys.version_info[1] < 3):
107+
import ipaddr as ipaddress #pylint:disable=F0401
107108
ipaddress.ip_address = ipaddress.IPAddress
108109
else:
109-
import ipaddress
110+
import ipaddress #pylint:disable=F0401
110111

111112
class Client(object):
112113
"""This method creates a new client object.

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818

1919
requirements = [i.strip() for i in open("requirements.txt").readlines()]
2020

21-
if sys.version_info[0] == 2:
21+
if sys.version_info[0] == 2 or (sys.version_info[0] == 3
22+
and sys.version_info[1] < 3):
2223
requirements.append('ipaddr')
2324

2425
setup(

0 commit comments

Comments
 (0)