Skip to content

Commit 8dc844c

Browse files
committed
Remove user_id support
1 parent 219473d commit 8dc844c

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

geoip2/webservice.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,21 +93,11 @@ def __init__(
9393
host="geoip.maxmind.com",
9494
locales=None,
9595
timeout=None,
96-
# This is deprecated and not documented for that reason.
97-
# It can be removed if we do a major release in the future.
98-
user_id=None,
9996
):
10097
"""Construct a Client."""
10198
# pylint: disable=too-many-arguments
10299
if locales is None:
103100
locales = ["en"]
104-
if account_id is None:
105-
account_id = user_id
106-
107-
if account_id is None:
108-
raise TypeError("The account_id is a required parameter")
109-
if license_key is None:
110-
raise TypeError("The license_key is a required parameter")
111101

112102
self._locales = locales
113103
# requests 2.12.2 requires that the username passed to auth be bytes

tests/webservice_test.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -339,12 +339,9 @@ def test_insights_ok(self, mock):
339339
def test_named_constructor_args(self):
340340
id = "47"
341341
key = "1234567890ab"
342-
for client in (
343-
Client(account_id=id, license_key=key),
344-
Client(user_id=id, license_key=key),
345-
):
346-
self.assertEqual(client._account_id, id)
347-
self.assertEqual(client._license_key, key)
342+
client = Client(account_id=id, license_key=key)
343+
self.assertEqual(client._account_id, id)
344+
self.assertEqual(client._license_key, key)
348345

349346
def test_missing_constructor_args(self):
350347
with self.assertRaises(TypeError):

0 commit comments

Comments
 (0)