Fix release script consistency issues

- Remove redundant git push --tags (gh release create handles tags)
- Fix shellcheck SC2162: add -r flag to read command
- Apply shfmt formatting

Author: oschwald

dev-bin/release.sh

@@ -6,28 +6,28 @@ set -eu -o pipefail
 # before making any changes to the repository
 
 check_command() {
-    if ! command -v "$1" &> /dev/null; then
-        echo "Error: $1 is not installed or not in PATH"
-        exit 1
-    fi
+	if ! command -v "$1" &>/dev/null; then
+		echo "Error: $1 is not installed or not in PATH"
+		exit 1
+	fi
 }
 
 # Verify gh CLI is authenticated
-if ! gh auth status &> /dev/null; then
-    echo "Error: gh CLI is not authenticated. Run 'gh auth login' first."
-    exit 1
+if ! gh auth status &>/dev/null; then
+	echo "Error: gh CLI is not authenticated. Run 'gh auth login' first."
+	exit 1
 fi
 
 # Verify we can access this repository via gh
-if ! gh repo view --json name &> /dev/null; then
-    echo "Error: Cannot access repository via gh. Check your authentication and repository access."
-    exit 1
+if ! gh repo view --json name &>/dev/null; then
+	echo "Error: Cannot access repository via gh. Check your authentication and repository access."
+	exit 1
 fi
 
 # Verify git can connect to the remote (catches SSH key issues, etc.)
-if ! git ls-remote origin &> /dev/null; then
-    echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys."
-    exit 1
+if ! git ls-remote origin &>/dev/null; then
+	echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys."
+	exit 1
 fi
 
 check_command perl
@@ -36,19 +36,19 @@ check_command uv
 # Check that we're not on the main branch
 current_branch=$(git branch --show-current)
 if [ "$current_branch" = "main" ]; then
-    echo "Error: Releases should not be done directly on the main branch."
-    echo "Please create a release branch and run this script from there."
-    exit 1
+	echo "Error: Releases should not be done directly on the main branch."
+	echo "Please create a release branch and run this script from there."
+	exit 1
 fi
 
 # Fetch latest changes and check that we're not behind origin/main
 echo "Fetching from origin..."
 git fetch origin
 
 if ! git merge-base --is-ancestor origin/main HEAD; then
-    echo "Error: Current branch is behind origin/main."
-    echo "Please merge or rebase with origin/main before releasing."
-    exit 1
+	echo "Error: Current branch is behind origin/main."
+	echo "Please merge or rebase with origin/main before releasing."
+	exit 1
 fi
 
 changelog=$(cat HISTORY.rst)
@@ -62,24 +62,24 @@ regex='
 '
 
 if [[ ! $changelog =~ $regex ]]; then
-      echo "Could not find date line in change log!"
-      exit 1
+	echo "Could not find date line in change log!"
+	exit 1
 fi
 
 version="${BASH_REMATCH[1]}"
 date="${BASH_REMATCH[3]}"
 notes="$(echo "${BASH_REMATCH[4]}" | sed -n -E '/^[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?/,$!p')"
 
 if [[ "$date" != "$(date +"%Y-%m-%d")" ]]; then
-    echo "$date is not today!"
-    exit 1
+	echo "$date is not today!"
+	exit 1
 fi
 
 tag="v$version"
 
 if [ -n "$(git status --porcelain)" ]; then
-    echo ". is not clean." >&2
-    exit 1
+	echo ". is not clean." >&2
+	exit 1
 fi
 
 perl -pi -e "s/(?<=^version = \").+?(?=\")/$version/gsm" pyproject.toml
@@ -93,17 +93,15 @@ git diff
 echo $'\nRelease notes:'
 echo "$notes"
 
-read -e -p "Commit changes and push to origin? " should_push
+read -r -e -p "Commit changes and push to origin? " should_push
 
 if [ "$should_push" != "y" ]; then
-    echo "Aborting"
-    exit 1
+	echo "Aborting"
+	exit 1
 fi
 
 git commit -m "Update for $tag" -a
 
 git push
 
 gh release create --target "$(git branch --show-current)" -t "$version" -n "$notes" "$tag"
-
-git push --tags